Merge ~sylvain-pineau/checkbox-support:fix-1647670 into checkbox-support:master

[Sylvain Pineau]

Fixes linked bug by adding the missing field to the submission parser.
Tested using "plainbox dev parse submission". All the new fields are in the json output:

http://pastebin.ubuntu.com/23588321/ (line 11354)

[Maciej Kisielewski (kissiel)]

LGTM! +1

review: Approve

diff --git a/checkbox_support/parsers/submission.py b/checkbox_support/parsers/submission.py
index d6ab8a6..f117c29 100644
--- a/checkbox_support/parsers/submission.py
+++ b/checkbox_support/parsers/submission.py
@@ -859,8 +859,11 @@ class SubmissionResult(object):
         snap_package_version = {
             "name": snap_package.get("name"),
             "version": snap_package.get("properties", {}).get("version"),
-            "date": snap_package.get("properties", {}).get("date"),
+            "install-date": snap_package.get("properties", {}).get("install-date"),
             "developer": snap_package.get("properties", {}).get("developer"),
+            "confinement": snap_package.get("properties", {}).get("confinement"),
+            "revision": snap_package.get("properties", {}).get("revision"),
+            "channel": snap_package.get("properties", {}).get("channel"),
             }
         self.dispatcher.publishEvent(
             "snap_package_version", snap_package_version)
diff --git a/checkbox_support/parsers/tests/fixtures/submission_snap_packages_with_date.xml b/checkbox_support/parsers/tests/fixtures/submission_snap_packages_with_date.xml
index 8579897..2ee6a92 100644
--- a/checkbox_support/parsers/tests/fixtures/submission_snap_packages_with_date.xml
+++ b/checkbox_support/parsers/tests/fixtures/submission_snap_packages_with_date.xml
@@ -2,11 +2,16 @@
 <system version="1.0">
 <software>
 <snap_packages>
-<snap_package id="0" name="ubuntu-core">
-<property name="version" type="str">14</property>
-<property name="date" type="str">2015-10-13</property>
-<property name="developer" type="str">ubuntu</property>
-</snap_package>
+  <snap_package id="0" name="core">
+    <property name="channel" type="str">edge</property>
+    <property name="confinement" type="str">strict</property>
+    <property name="developer" type="str">canonical</property>
+    <property name="devmode" type="str">False</property>
+    <property name="install-date" type="str">2016-12-05T16:07:14+01:00</property>
+    <property name="revision" type="str">620</property>
+    <property name="type" type="str">os</property>
+    <property name="version" type="str">16.04.1</property>
+  </snap_package>
 </snap_packages>
 </software>
 </system>
diff --git a/checkbox_support/parsers/tests/test_submission.py b/checkbox_support/parsers/tests/test_submission.py
index e51e664..b1075a3 100644
--- a/checkbox_support/parsers/tests/test_submission.py
+++ b/checkbox_support/parsers/tests/test_submission.py
@@ -358,10 +358,13 @@ class TestSubmissionParser(TestCase):
         self.assertEqual(len(result["snap_package_versions"]), 1)
 
         package_version = result["snap_package_versions"][0]
-        self.assertEqual(package_version["name"], "ubuntu-core")
-        self.assertEqual(package_version["version"], "14")
-        self.assertEqual(package_version["date"], "2015-10-13")
-        self.assertEqual(package_version["developer"], "ubuntu")
+        self.assertEqual(package_version["name"], "core")
+        self.assertEqual(package_version["version"], "16.04.1")
+        self.assertEqual(package_version["install-date"], "2016-12-05T16:07:14+01:00")
+        self.assertEqual(package_version["developer"], "canonical")
+        self.assertEqual(package_version["confinement"], "strict")
+        self.assertEqual(package_version["revision"], "620")
+        self.assertEqual(package_version["channel"], "edge")
 
     def test_package_modaliases(self):
         """