~sylvain-pineau/checkbox-ng:os_getenv_user_precheck

Branch merges

Propose for merging

Merged into checkbox-ng:master at revision 0feb35dd2875599d20b7608dbcb55837013eedf4

Maciej Kisielewski: Approve on 2018-04-10

Diff: 29 lines (+4/-3)

2 files modified

plainbox/impl/ctrl.py (+2/-2)
plainbox/impl/session/restart.py (+2/-1)

api

Related source package recipes

No recipes using this branch. (?)

Create packaging recipe

Related snap packages

Related charm recipes

fb7adae... by Sylvain Pineau on 2018-04-10

Check if os.getenv('USER') returns something before assuming a USER is defined

When checkbox is invoked a systemd service unit running as root, the USER env
variable is not defined leading to a crash in both ctrl and restart modules:

        user_mod = os.getenv('USER').replace('.', '%2E')
    AttributeError: 'NoneType' object has no attribute 'replace'

4a3d39b... by PMR <pmr@pmr-lander> on 2018-03-30

Merge #342447 from ~sylvain-pineau/checkbox-ng:typo_loaded

e3305b9... by Sylvain Pineau on 2018-03-30

typo

72829a1... by PMR <pmr@pmr-lander> on 2018-03-23

Merge #341779 from ~kissiel/checkbox-ng:remote-usability-improv

4872099... by Maciej Kisielewski on 2018-03-20

remote: do a warm-up password query if any job will require the password

Signed-off-by: Maciej Kisielewski <email address hidden>

c9b8a0b... by Maciej Kisielewski on 2018-03-20

add user to job representation proxies

Signed-off-by: Maciej Kisielewski <email address hidden>

e0faa88... by Maciej Kisielewski on 2018-03-20

remote: remove the extra call to finish_session

Signed-off-by: Maciej Kisielewski <email address hidden>

55808a6... by Maciej Kisielewski on 2018-03-20

remote: always call _prepare_transports when invoking remote-control

Signed-off-by: Maciej Kisielewski <email address hidden>

567adfb... by Maciej Kisielewski on 2018-03-20

refactor selecting tp

Signed-off-by: Maciej Kisielewski <email address hidden>

b9c1e38... by Maciej Kisielewski on 2018-03-20

split bootstrapping into two stages

the first stage checks if any of the bootstrapping jobs will require sudo
password, and the second will do the actual bootstrapping.

Signed-off-by: Maciej Kisielewski <email address hidden>