Merge ~sylvain-pineau/checkbox-ng:fix-multi-page.html into checkbox-ng:master

Proposed by Sylvain Pineau
Status: Merged
Approved by: Sylvain Pineau
Approved revision: 95cde83cc0676c18a4d3294f72a169c0caac3c10
Merged at revision: cf1a3eb23177c75b2ed5abfe0e3b83a8e82764a9
Proposed branch: ~sylvain-pineau/checkbox-ng:fix-multi-page.html
Merge into: checkbox-ng:master
Diff against target: 13 lines (+1/-1)
1 file modified
plainbox/impl/providers/exporters/data/multi-page.html (+1/-1)
Reviewer Review Type Date Requested Status
Sylvain Pineau (community) Approve
Review via email: mp+402790@code.launchpad.net

Description of the change

See commit msg. the top dropdown list select menu was wrongly set if more than 10 pages were created. Basically selecting the 14th was displaying the 4th in the menu (the html page was correct though)

To post a comment you must log in.
Revision history for this message
Sylvain Pineau (sylvain-pineau) wrote :

self-approved

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/plainbox/impl/providers/exporters/data/multi-page.html b/plainbox/impl/providers/exporters/data/multi-page.html
2index aee86ec..e41f4ec 100644
3--- a/plainbox/impl/providers/exporters/data/multi-page.html
4+++ b/plainbox/impl/providers/exporters/data/multi-page.html
5@@ -51,7 +51,7 @@
6 }
7 if (ui.toPage[0].id === "session-{{ loop.index - 1 }}") {
8 var target_id = ui.toPage[0].id
9- var desired_index = target_id.charAt(target_id.length-1)
10+ var desired_index = {{ loop.index - 1 }}
11 var myselect = $("#select-report{{ loop.index - 1 }}");
12 myselect[0].selectedIndex = desired_index;
13 myselect.selectmenu("refresh");

Subscribers

People subscribed via source and target branches