Merge ~sylvain-pineau/checkbox-ng:fix-xdg-restart into checkbox-ng:master

[Sylvain Pineau]

Fix the XDG restart strategy by prefixing the Desktop file Exec cmd with sh -c

Tested using checkbox-cli and the power-automated test plan

[Sylvain Pineau (sylvain-pineau)]

self-approved

review: Approve

diff --git a/plainbox/impl/session/restart.py b/plainbox/impl/session/restart.py
index 8dc93e8..b3c72cd 100644
--- a/plainbox/impl/session/restart.py
+++ b/plainbox/impl/session/restart.py
@@ -111,6 +111,9 @@ class XDGRestartStrategy(IRestartStrategy):
     def prime_application_restart(self, app_id: str,
                                   session_id: str, cmd: str) -> None:
         filename = self.get_desktop_filename(app_id)
+        # Prefix the command with sh -c to comply with the Exec spec
+        # See https://askubuntu.com/a/1242773/32239
+        cmd = "sh -c " + cmd
         if self.app_terminal:
             cmd += ';$SHELL'
         self.config.set('Desktop Entry', 'Exec', cmd)