Merge ~sylvain-pineau/checkbox-ng:fix-provider-manager-encoding into checkbox-ng:master

Proposed by Sylvain Pineau
Status: Merged
Approved by: Sylvain Pineau
Approved revision: 012e74efe00297f178921a1bec8da54074da6357
Merged at revision: c927ace3c1f8e71c08342a5f2d95fdad705d03f6
Proposed branch: ~sylvain-pineau/checkbox-ng:fix-provider-manager-encoding
Merge into: checkbox-ng:master
Diff against target: 12 lines (+1/-1)
1 file modified
plainbox/provider_manager.py (+1/-1)
Reviewer Review Type Date Requested Status
Sylvain Pineau (community) Approve
Review via email: mp+387511@code.launchpad.net

Description of the change

I can't use (yet) subprocess.run encoding, it's 3.6+. Fallback to universal_newlines

To post a comment you must log in.
Revision history for this message
Sylvain Pineau (sylvain-pineau) wrote :

self-approved

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/plainbox/provider_manager.py b/plainbox/provider_manager.py
2index 58748ae..4332eb1 100644
3--- a/plainbox/provider_manager.py
4+++ b/plainbox/provider_manager.py
5@@ -1345,7 +1345,7 @@ def create_inline_shellcheck_test(command):
6 result = subprocess.run(
7 ['shellcheck', '-', '--shell=bash'],
8 input=command,
9- encoding='ascii')
10+ universal_newlines=True)
11 self.assertEqual(result.returncode, 0)
12 return run_inline_shellcheck
13

Subscribers

People subscribed via source and target branches