Merge ~sylvain-pineau/checkbox-ng:inline_shellcheck_flake8 into checkbox-ng:master
Proposed by
Sylvain Pineau
Status: | Merged |
---|---|
Approved by: | Sylvain Pineau |
Approved revision: | 8ed75ea6665e75a1f98f0e2cb6d5cface0ec41af |
Merged at revision: | ac158658dd61cecfde0c89c0e2c5fb5accad2c40 |
Proposed branch: | ~sylvain-pineau/checkbox-ng:inline_shellcheck_flake8 |
Merge into: | checkbox-ng:master |
Diff against target: |
195 lines (+136/-9) 1 file modified
plainbox/provider_manager.py (+136/-9) |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Jonathan Cave (community) | Approve | ||
Sylvain Pineau (community) | Needs Resubmitting | ||
Review via email:
|
Description of the change
Extend the existing manage.py test command by adding flake8 for python3 scripts and support for inline command shellcheck.
Sample output for p-p-c:
Ran 940 tests in 16.485s
FAILED (failures=367)
To post a comment you must log in.
I've added a subparser to run only a subset of the tests, so that we can work of fixing e.g shellcheck errors while still running the unit tests from PMR.
For instance:
./manage.py test -u
will only run the unit tests.
Default is still running all sort of tests.
But with the various options, we can easily modify our pmr hooks to run the tests we consider ready.