Merge ~sylvain-pineau/checkbox-ng:no_tty_no_tqdm into checkbox-ng:master

[Sylvain Pineau]

tqdm progress bar are messing up jenkins console logs.
tqdm supports a disable flag, let's use it when there's no tty.

[Maciej Kisielewski (kissiel)]

LGTM, +1

review: Approve

[Jonathan Cave (jocave)]

LGTM

review: Approve

diff --git a/checkbox_ng/launcher/master.py b/checkbox_ng/launcher/master.py
index 8c29e91..9009266 100644
--- a/checkbox_ng/launcher/master.py
+++ b/checkbox_ng/launcher/master.py
@@ -453,28 +453,18 @@ class RemoteMaster(ReportsStage, MainLoopStage):
         self.abandon()
         self.new_session()
 
-    def _download_file(conn, remotepath, localpath, chunk_size=16384):
-        try:
-            rf = conn.root.open(remotepath, "rb")
-            with tqdm(total=conn.root.getsize(remotepath), unit='B', unit_scale=True, unit_divisor=1024) as pbar:
-                with open(localpath, "wb") as lf:
-                    while True:
-                        buf = rf.read(chunk_size)
-                        pbar.set_postfix(file=remotepath, refresh=False)
-                        pbar.update(chunk_size)
-                        if not buf:
-                            break
-                        #time.sleep(0.01)
-                        lf.write(buf)
-        finally:
-            rf.close()
-
     def local_export(self, exporter_id, transport, options=()):
         _logger.info("master: Exporting locally'")
         rf = self.sa.cache_report(exporter_id, options)
         exported_stream = SpooledTemporaryFile(max_size=102400, mode='w+b')
-        chunk_size=16384
-        with tqdm(total=rf.tell(), unit='B', unit_scale=True, unit_divisor=1024) as pbar:
+        chunk_size = 16384
+        with tqdm(
+            total=rf.tell(),
+            unit='B',
+            unit_scale=True,
+            unit_divisor=1024,
+            disable=not self.is_interactive
+        ) as pbar:
             rf.seek(0)
             while True:
                 buf = rf.read(chunk_size)