Merge ~sylvain-pineau/checkbox-ng:fix-manifest-test-selection-forced into checkbox-ng:master

[Sylvain Pineau]

Fix manifest json representation when test selection is forced to avoid recording to json string value (e.g "True") instead of true.

[Jonathan Cave (jocave)]

Thanks. This looks to fix the scenario I had been testing with for both local and remote invocations.

review: Approve

diff --git a/checkbox_ng/launcher/master.py b/checkbox_ng/launcher/master.py
index 2107fbf..fd14a54 100644
--- a/checkbox_ng/launcher/master.py
+++ b/checkbox_ng/launcher/master.py
@@ -285,11 +285,15 @@ class RemoteMaster(ReportsStage, MainLoopStage):
         self._is_bootstrapping = False
         self.jobs = self.sa.finish_bootstrap()
 
+    def _strtobool(self, val):
+        return val.lower() in ('y', 'yes', 't', 'true', 'on', '1')
+
     def select_jobs(self, all_jobs):
         if self.launcher.test_selection_forced:
             if self.launcher.manifest is not Unset:
                 self.sa.save_manifest(
-                    {manifest_id: self.launcher.manifest[manifest_id] for
+                    {manifest_id:
+                     self._strtobool(self.launcher.manifest[manifest_id]) for
                      manifest_id in self.launcher.manifest}
                 )
         else:
diff --git a/checkbox_ng/launcher/subcommands.py b/checkbox_ng/launcher/subcommands.py
index 7427522..0432cdb 100644
--- a/checkbox_ng/launcher/subcommands.py
+++ b/checkbox_ng/launcher/subcommands.py
@@ -400,11 +400,15 @@ class Launcher(MainLoopStage, ReportsStage):
             self.launcher.test_plan_default_selection).run()
         return selected_tp
 
+    def _strtobool(self, val):
+        return val.lower() in ('y', 'yes', 't', 'true', 'on', '1')
+
     def _pick_jobs_to_run(self):
         if self.launcher.test_selection_forced:
             if self.launcher.manifest is not Unset:
                 self.ctx.sa.save_manifest(
-                    {manifest_id: self.launcher.manifest[manifest_id] for
+                    {manifest_id:
+                     self._strtobool(self.launcher.manifest[manifest_id]) for
                      manifest_id in self.launcher.manifest}
                 )
             # by default all tests are selected; so we're done here