Merge ~sylvain-pineau/checkbox-ng:remove_test_pod_namedtuple_internals into checkbox-ng:master

Proposed by Sylvain Pineau
Status: Merged
Approved by: Sylvain Pineau
Approved revision: af79c3d2d4b4e6d6271eb4a1147a78b56a3c72c0
Merged at revision: 5b6390cd2e7ade19c3ed9e99fbe29feb763c8c4b
Proposed branch: ~sylvain-pineau/checkbox-ng:remove_test_pod_namedtuple_internals
Merge into: checkbox-ng:master
Diff against target: 14 lines (+0/-3)
1 file modified
plainbox/impl/test_pod.py (+0/-3)
Reviewer Review Type Date Requested Status
Sylvain Pineau (community) Approve
Review via email: mp+376033@code.launchpad.net

Description of the change

Fixes the focal builds by removing a check on namedtuple internals:

======================================================================
FAIL: test_namedtuple_cls (plainbox.impl.test_pod.PODTests)
Check that .namedtuple_cls is set up by PODMeta.
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/<<BUILDDIR>>/checkbox-ng-1.6.0+git201911251424+pkg137~ubuntu20.04.1/plainbox/impl/test_pod.py", line 307, in test_namedtuple_cls
    self.assertIsInstance(T.namedtuple_cls.f1, property)
AssertionError: <_collections._tuplegetter object at 0x7fec3bcd22e0> is not an instance of <class 'property'>

----------------------------------------------------------------------
Ran 1758 tests in 14.210s

FAILED (failures=1, expected failures=2)
Test failed: <unittest.runner.TextTestResult run=1758 errors=0 failures=1>
error: Test failed: <unittest.runner.TextTestResult run=1758 errors=0 failures=1>
E: pybuild pybuild:341: test: plugin distutils failed with: exit code=1: python3.8 setup.py test

To post a comment you must log in.
Revision history for this message
Sylvain Pineau (sylvain-pineau) wrote :

self-approved

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/plainbox/impl/test_pod.py b/plainbox/impl/test_pod.py
2index 02e9262..5f0ae9c 100644
3--- a/plainbox/impl/test_pod.py
4+++ b/plainbox/impl/test_pod.py
5@@ -304,9 +304,6 @@ class PODTests(TestCase):
6 f3 = Field(initial_fn=lambda: m())
7
8 self.assertEqual(T.namedtuple_cls.__name__, 'T')
9- self.assertIsInstance(T.namedtuple_cls.f1, property)
10- self.assertIsInstance(T.namedtuple_cls.f2, property)
11- self.assertIsInstance(T.namedtuple_cls.f3, property)
12
13 def test_initializer_positional_arguments(self):
14 """.__init__() works correctly with positional arguments."""

Subscribers

People subscribed via source and target branches