Merge ~sylvain-pineau/checkbox-ng:master_socket_timeout_60s into checkbox-ng:master

Proposed by Sylvain Pineau
Status: Merged
Approved by: Sylvain Pineau
Approved revision: 48cf86457e3cd397bfcdf3fc4c0b151612d87ab3
Merged at revision: e4abc58e72eb671dd37f7a0de8dd5cf82d66cc46
Proposed branch: ~sylvain-pineau/checkbox-ng:master_socket_timeout_60s
Merge into: checkbox-ng:master
Diff against target: 12 lines (+1/-0)
1 file modified
checkbox_ng/launcher/master.py (+1/-0)
Reviewer Review Type Date Requested Status
Jonathan Cave (community) Approve
Review via email: mp+375143@code.launchpad.net

Description of the change

30s is sometimes not enough on slow devices while templating new jobs from the device/udev job. Extending to 60s

To post a comment you must log in.
Revision history for this message
Jonathan Cave (jocave) wrote :

+1, looks like there is confidence this is the source of recent problems and logging should be in place to capture any unexpected consequences

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/checkbox_ng/launcher/master.py b/checkbox_ng/launcher/master.py
2index 09e717e..818e78d 100644
3--- a/checkbox_ng/launcher/master.py
4+++ b/checkbox_ng/launcher/master.py
5@@ -149,6 +149,7 @@ class RemoteMaster(Command, ReportsStage, MainLoopStage):
6 def connect_and_run(self, host, port=18871):
7 config = rpyc.core.protocol.DEFAULT_CONFIG.copy()
8 config['allow_all_attrs'] = True
9+ config['sync_request_timeout'] = 60
10 keep_running = False
11 self._prepare_transports()
12 interrupted = False

Subscribers

People subscribed via source and target branches