Merge ~sylvain-pineau/checkbox-ng:psutilAccessDenied into checkbox-ng:master

[Sylvain Pineau]

Avoid a crash if the checkbox slave is started with a normal user (not root).

Note that's not the recommended way since all remote slaves are meant to run as root (from debs and snaps)

[Jonathan Cave (jocave)]

+1

review: Approve

[Taihsiang Ho (tai271828)]

Thanks for the quick fix. Let's land it and have a try.

review: Approve

diff --git a/plainbox/impl/session/remote_assistant.py b/plainbox/impl/session/remote_assistant.py
index 35a5b11..948a5f5 100644
--- a/plainbox/impl/session/remote_assistant.py
+++ b/plainbox/impl/session/remote_assistant.py
@@ -190,8 +190,11 @@ class RemoteSessionAssistant():
         # If possible also set the DISPLAY env var
         # i.e when a user desktop session is running
         for p in psutil.pids():
-            p_environ = psutil.Process(p).environ()
-            p_user = psutil.Process(p).username()
+            try:
+                p_environ = psutil.Process(p).environ()
+                p_user = psutil.Process(p).username()
+            except psutil.AccessDenied:
+                continue
             if ("DISPLAY" in p_environ and p_user != 'gdm'):  # gdm uses :1024
                 return {'DISPLAY': p_environ['DISPLAY']}
                 break