Merge ~sylvain-pineau/checkbox-ng:fix-1841702 into checkbox-ng:master
Proposed by
Sylvain Pineau
Status: | Rejected | ||||
---|---|---|---|---|---|
Rejected by: | Sylvain Pineau | ||||
Proposed branch: | ~sylvain-pineau/checkbox-ng:fix-1841702 | ||||
Merge into: | checkbox-ng:master | ||||
Diff against target: |
72 lines (+4/-37) 1 file modified
plainbox/impl/execution.py (+4/-37) |
||||
Related bugs: |
|
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Maciej Kisielewski (community) | Disapprove | ||
Checkbox Developers | Pending | ||
Review via email:
|
Description of the change
Fixes the linked bug.
The new unified runner introduced and intermediate player, stdin_forwarder() which creates a deadlock with commands like:
$ more foo | cat
The proposed patch is using a method originally found in RootViaSudoWith
[1] can be found in the last stable release: https:/
Maciej, could you please check I'm not breaking remote features by annihilating this stdin_forwarder()?
To post a comment you must log in.
stdin is not only for supplying password, but also for sending input to jobs that read stdin.
Like collect manifest for instance. So we need the red bit, I'm affraid.