Merge ~sylvain-pineau/checkbox-ng:improve-loading-time-multi-page into checkbox-ng:master

Proposed by Sylvain Pineau
Status: Merged
Approved by: Sylvain Pineau
Approved revision: ecb54c4607d9f01f809b1d37b4016f9c0cd1bcce
Merged at revision: 4670c4e558a27c6051048e3a5c3af32159a76bfb
Proposed branch: ~sylvain-pineau/checkbox-ng:improve-loading-time-multi-page
Merge into: checkbox-ng:master
Diff against target: 14 lines (+0/-3)
1 file modified
plainbox/impl/providers/exporters/data/multi-page.html (+0/-3)
Reviewer Review Type Date Requested Status
Sylvain Pineau (community) Approve
Review via email: mp+358380@code.launchpad.net

Description of the change

Remove unnecessary JS code causing slowness when loading a multi-page html report.

Tested with argos (See SRU reports for this cycle)

To post a comment you must log in.
Revision history for this message
Sylvain Pineau (sylvain-pineau) wrote :

self-approved

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/plainbox/impl/providers/exporters/data/multi-page.html b/plainbox/impl/providers/exporters/data/multi-page.html
2index de5c416..6f8beb2 100644
3--- a/plainbox/impl/providers/exporters/data/multi-page.html
4+++ b/plainbox/impl/providers/exporters/data/multi-page.html
5@@ -22,9 +22,6 @@
6 {{ include_file("Chart.min.js") }}
7 </script>
8 <script>
9- $(function(){
10- $( "[data-role='header']" ).toolbar();
11- });
12 {%- for manager in manager_list %}
13 $(function(){
14 // bind change event to select

Subscribers

People subscribed via source and target branches