Merge ~sylvain-pineau/checkbox-ng:fix-1790050 into checkbox-ng:master

Proposed by Sylvain Pineau
Status: Merged
Approved by: Sylvain Pineau
Approved revision: 9aaebc129d408b39b4c9bed92eccde1c79dcc3c1
Merged at revision: d45e00954b1af7038a452dff58912951d5508f75
Proposed branch: ~sylvain-pineau/checkbox-ng:fix-1790050
Merge into: checkbox-ng:master
Diff against target: 23 lines (+3/-2)
1 file modified
plainbox/impl/session/assistant.py (+3/-2)
Reviewer Review Type Date Requested Status
Sylvain Pineau (community) Approve
Review via email: mp+354093@code.launchpad.net

Description of the change

Fixes linked bug by setting the runner class when resuming sessions

To post a comment you must log in.
Revision history for this message
Sylvain Pineau (sylvain-pineau) wrote :

self-approved, tested on 18.04 with unfinished sessions. resuming succeeded

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/plainbox/impl/session/assistant.py b/plainbox/impl/session/assistant.py
2index 995e38b..2595ae8 100644
3--- a/plainbox/impl/session/assistant.py
4+++ b/plainbox/impl/session/assistant.py
5@@ -603,7 +603,8 @@ class SessionAssistant:
6 }
7
8 @raises(KeyError, UnexpectedMethodCall)
9- def resume_session(self, session_id: str) -> 'SessionMetaData':
10+ def resume_session(self, session_id: str,
11+ runner_cls=JobRunner) -> 'SessionMetaData':
12 """
13 Resume a session.
14
15@@ -631,7 +632,7 @@ class SessionAssistant:
16 self._context = self._manager.default_device_context
17 self._metadata = self._context.state.metadata
18 self._command_io_delegate = JobRunnerUIDelegate(_SilentUI())
19- self._init_runner()
20+ self._init_runner(runner_cls)
21 if self._metadata.running_job_name:
22 job = self._context.get_unit(
23 self._metadata.running_job_name, 'job')

Subscribers

People subscribed via source and target branches