Merge ~sylvain-pineau/checkbox-ng:new_submission_service_urls into checkbox-ng:master

Proposed by Sylvain Pineau
Status: Merged
Approved by: Sylvain Pineau
Approved revision: a4d73e6ed3c12bcf6fb53aef9f8daa09ef98e30e
Merged at revision: 773bae80202f464e41bb2b53ec19e428584f4b4d
Proposed branch: ~sylvain-pineau/checkbox-ng:new_submission_service_urls
Merge into: checkbox-ng:master
Diff against target: 17 lines (+2/-2)
1 file modified
checkbox_ng/launcher/subcommands.py (+2/-2)
Reviewer Review Type Date Requested Status
Sheila Miguez (community) Approve
Checkbox Developers Pending
Review via email: mp+322113@code.launchpad.net

Description of the change

Per Sheila's request, update of the two urls defined to send tarballs to the new submission service endpoint.

To post a comment you must log in.
Revision history for this message
Sheila Miguez (codersquid) wrote :

LGTM

one day would you want to make it so that someone can specify the endpoint so that you can do something like submit to an alternate env?

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/checkbox_ng/launcher/subcommands.py b/checkbox_ng/launcher/subcommands.py
2index 7fb6b3e..7f52cda 100644
3--- a/checkbox_ng/launcher/subcommands.py
4+++ b/checkbox_ng/launcher/subcommands.py
5@@ -577,10 +577,10 @@ class Launcher(Command, MainLoopStage):
6 options = ""
7 if self.launcher.transports[transport].get('staging', False):
8 url = ('https://submission.staging.canonical.com/'
9- '1.0/submission/hardware/{}'.format(secure_id))
10+ 'v1/submission/hardware/{}'.format(secure_id))
11 else:
12 url = ('https://submission.canonical.com/'
13- '1.0/submission/hardware/{}'.format(secure_id))
14+ 'v1/submission/hardware/{}'.format(secure_id))
15 self.transports[transport] = cls(url, options)
16
17 def _export_results(self):

Subscribers

People subscribed via source and target branches