Merge ~sylvain-pineau/checkbox-ng:no_hide_if_chunked_io into checkbox-ng:master

Proposed by Sylvain Pineau
Status: Merged
Approved by: Sylvain Pineau
Approved revision: 5f84fcc5a20d877c67faeb8f3e75dae70db4be56
Merged at revision: 38c9077331a94fb31973d351f95b7275e39a2ca2
Proposed branch: ~sylvain-pineau/checkbox-ng:no_hide_if_chunked_io
Merge into: checkbox-ng:master
Diff against target: 13 lines (+2/-0)
1 file modified
checkbox_ng/launcher/subcommands.py (+2/-0)
Reviewer Review Type Date Requested Status
Maciej Kisielewski (community) Approve
Sylvain Pineau (community) Approve
Review via email: mp+308934@code.launchpad.net

Description of the change

The hide launcher ui option does not allow jobs commands requiring user interaction to prompt their questions(e.g the plainbox manifest collect job).

Those can be identified with the use-chunked-io flag. Let's avoid hide their i/o if it's set.

To post a comment you must log in.
Revision history for this message
Sylvain Pineau (sylvain-pineau) wrote :

self-approved

review: Approve
Revision history for this message
Maciej Kisielewski (kissiel) wrote :

post mortem +1 :)

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/checkbox_ng/launcher/subcommands.py b/checkbox_ng/launcher/subcommands.py
2index e83a54f..74482f8 100644
3--- a/checkbox_ng/launcher/subcommands.py
4+++ b/checkbox_ng/launcher/subcommands.py
5@@ -587,6 +587,8 @@ class Launcher(Command, MainLoopStage):
6 show_out = False
7 if 'suppress-output' in job.get_flag_set():
8 show_out = False
9+ if 'use-chunked-io' in job.get_flag_set():
10+ show_out = True
11 return CheckboxUI(self.C.c, show_cmd_output=show_out)
12
13 def register_arguments(self, parser):

Subscribers

People subscribed via source and target branches