Merge ~sylvain-pineau/checkbox-limerick/+git/checkbox-provider-limerick:firmware-deb into ~checkbox-dev/checkbox-limerick/+git/checkbox-provider-limerick:master

Proposed by Sylvain Pineau
Status: Merged
Approved by: Sylvain Pineau
Approved revision: fb6a8d26c4507fa06827a94975e0afdfae5033f1
Merged at revision: e9b44571d825abc422e7db746262ff1067b61c84
Proposed branch: ~sylvain-pineau/checkbox-limerick/+git/checkbox-provider-limerick:firmware-deb
Merge into: ~checkbox-dev/checkbox-limerick/+git/checkbox-provider-limerick:master
Diff against target: 47 lines (+4/-5)
3 files modified
bin/component_test.py (+2/-4)
units/components/jobs.pxu (+1/-1)
units/device/jobs.pxu (+1/-0)
Reviewer Review Type Date Requested Status
Sylvain Pineau (community) Approve
Review via email: mp+391799@code.launchpad.net

Description of the change

Use the firmware deb to load the DTB

To post a comment you must log in.
Revision history for this message
Sylvain Pineau (sylvain-pineau) wrote :

self-approved

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/bin/component_test.py b/bin/component_test.py
2index 4f4c4ba..eb296aa 100755
3--- a/bin/component_test.py
4+++ b/bin/component_test.py
5@@ -20,15 +20,13 @@
6 # along with Checkbox. If not, see <http://www.gnu.org/licenses/>.
7
8 import codecs
9-import glob
10 import os
11 import re
12 import subprocess
13 import sys
14
15-p = glob.glob('/usr/lib/firmware/*/device-tree/{}'.format(
16- codecs.decode("kvyvak", "rot-13")))[0]
17-dtb = os.path.join(p, '{}.dtb'.format(sys.argv[1]))
18+p = '/usr/share/{}'.format(codecs.decode("kyak-svezjner", "rot-13"))
19+dtb = os.path.join(p, sys.argv[1], '{}_system.dtb'.format(sys.argv[1]))
20 dt_lookup_list = []
21 exit_status = 0
22
23diff --git a/units/components/jobs.pxu b/units/components/jobs.pxu
24index 524bcd6..2968ef1 100644
25--- a/units/components/jobs.pxu
26+++ b/units/components/jobs.pxu
27@@ -2,7 +2,7 @@ unit: template
28 template-resource: limerick_sku
29 id: dtb/components_{name}
30 _summary: Check all DTB compatible properties are loaded in /proc/device-tree
31-command: component_test.py {name}
32+command: component_test.py {short_name}
33 plugin: shell
34 category_id: dtb_components
35 estimated_duration: 1m
36diff --git a/units/device/jobs.pxu b/units/device/jobs.pxu
37index 3a9fde5..19b36d1 100644
38--- a/units/device/jobs.pxu
39+++ b/units/device/jobs.pxu
40@@ -20,6 +20,7 @@ plugin: resource
41 _summary: Detect which Limerick SKU the tool is running on
42 command:
43 perl -ne 's/ /-/g;s/(.*?)([A-Z]?)\W+$/\L$1\U$2/; print "name: $_\n"' /proc/device-tree/model
44+ perl -ne 's/.*?\s(\S+).*/$1/i; print "short_name: \L$_\n\n"' /proc/device-tree/model
45 estimated_duration: 1s
46
47 id: device-connections-tp

Subscribers

People subscribed via source and target branches