Merge ~sylvain-pineau/checkbox-core-snap:base22_fixes into checkbox-core-snap:master

Proposed by Sylvain Pineau
Status: Rejected
Rejected by: Sylvain Pineau
Proposed branch: ~sylvain-pineau/checkbox-core-snap:base22_fixes
Merge into: checkbox-core-snap:master
Diff against target: 33 lines (+2/-2)
2 files modified
snap/plugins/checkbox_provider.py (+1/-1)
snap/snapcraft.yaml (+1/-1)
Reviewer Review Type Date Requested Status
Checkbox Developers Pending
Review via email: mp+416807@code.launchpad.net

Description of the change

Fixes required to build checkbox22.

Tested in a jammy lxc container

To post a comment you must log in.
Revision history for this message
Sylvain Pineau (sylvain-pineau) wrote :

joc rebased his py10 branch on this one and was merged last week:

https://git.launchpad.net/checkbox-core-snap/commit/?id=e01595e9aebd75bc562f2a92a6fd1029be2105cb

Unmerged commits

0799fc8... by Sylvain Pineau

base core22 fixes

- install pybluez from debs
- Fix the checkbox plugin get_build_environment() to adjust PYTHONPATH

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/snap/plugins/checkbox_provider.py b/snap/plugins/checkbox_provider.py
2index 4dedb20..9fc2286 100644
3--- a/snap/plugins/checkbox_provider.py
4+++ b/snap/plugins/checkbox_provider.py
5@@ -38,7 +38,7 @@ class PluginImpl(PluginV2):
6
7 def get_build_environment(self) -> Dict[str, str]:
8 if self.project._get_build_base() == "core22":
9- site_pkg_path = "$SNAPCRAFT_STAGE/lib/python3.9/site-packages"
10+ site_pkg_path = "$SNAPCRAFT_STAGE/local/lib/python3.10/dist-packages:$SNAPCRAFT_STAGE/usr/lib/python3/dist-packages"
11 else:
12 site_pkg_path = "$SNAPCRAFT_STAGE/lib/python3.8/site-packages"
13 return {"PYTHONPATH": site_pkg_path}
14diff --git a/snap/snapcraft.yaml b/snap/snapcraft.yaml
15index 33fa234..f044865 100644
16--- a/snap/snapcraft.yaml
17+++ b/snap/snapcraft.yaml
18@@ -134,6 +134,7 @@ parts:
19 source: git://git.launchpad.net/checkbox-support
20 stage-packages:
21 # actual requirements
22+ - python3-bluez
23 - python3-requests-unixsocket
24 - python3-systemd
25 # added to stage python:
26@@ -153,7 +154,6 @@ parts:
27 - python3-dev
28 python-packages:
29 - pynmea2
30- - pybluez
31 after: [acpi-tools]
32 stage:
33 - -pyvenv.cfg

Subscribers

People subscribed via source and target branches