Merge ~sylvain-pineau/checkbox-core-snap:add-lsb-release into checkbox-core-snap:master

Proposed by Sylvain Pineau
Status: Merged
Approved by: Sylvain Pineau
Approved revision: 7d12fa355b48893fb7c8e0f28c7831a1195f0a02
Merged at revision: 8e895038b218981adb6b65c8d8758b31affb6d11
Proposed branch: ~sylvain-pineau/checkbox-core-snap:add-lsb-release
Merge into: checkbox-core-snap:master
Diff against target: 12 lines (+1/-0)
1 file modified
snap/snapcraft.yaml (+1/-0)
Reviewer Review Type Date Requested Status
Sylvain Pineau (community) Approve
Review via email: mp+390967@code.launchpad.net

Description of the change

  File "/snap/checkbox-vasteras/14/checkbox-runtime/lib/python3.6/site-packages/distro.py", line 1014, in _lsb_release_info
    stdout = subprocess.check_output(cmd, stderr=devnull)
  File "/snap/checkbox-vasteras/14/checkbox-runtime/usr/lib/python3.6/subprocess.py", line 356, in check_output
    **kwargs).stdout
  File "/snap/checkbox-vasteras/14/checkbox-runtime/usr/lib/python3.6/subprocess.py", line 438, in run
    output=stdout, stderr=stderr)
subprocess.CalledProcessError: Command '('lsb_release', '-a')' returned non-zero exit status 1.

To post a comment you must log in.
Revision history for this message
Sylvain Pineau (sylvain-pineau) wrote :

self-approved

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/snap/snapcraft.yaml b/snap/snapcraft.yaml
2index 4c2019a..3449e7d 100644
3--- a/snap/snapcraft.yaml
4+++ b/snap/snapcraft.yaml
5@@ -122,6 +122,7 @@ parts:
6 source: git://git.launchpad.net/checkbox-support
7 stage-packages:
8 # actual requirements
9+ - lsb-release
10 - python3-requests-unixsocket
11 - python3-systemd
12 # added to stage python:

Subscribers

People subscribed via source and target branches