Merge ~sylvain-pineau/checkbox-core-snap:less-python-packages into checkbox-core-snap:master

Proposed by Sylvain Pineau
Status: Merged
Approved by: Sylvain Pineau
Approved revision: 21f7a654d48b95793d24ab1dfe012500451f339e
Merged at revision: 898ffe624ef37f265dba954b8b11161bb9e80744
Proposed branch: ~sylvain-pineau/checkbox-core-snap:less-python-packages
Merge into: checkbox-core-snap:master
Diff against target: 25 lines (+6/-6)
1 file modified
snap/snapcraft.yaml (+6/-6)
Reviewer Review Type Date Requested Status
Jonathan Cave (community) Approve
Sheila Miguez (community) Approve
Review via email: mp+375612@code.launchpad.net

Description of the change

Prefer the repo versions rather than pypi to satisfy checkbox-ng requirements. Sometimes unexpected updates severely break our core snaps/snapcraft.

To post a comment you must log in.
Revision history for this message
Sheila Miguez (codersquid) wrote :

ltgm

review: Approve
Revision history for this message
Jonathan Cave (jocave) wrote :

Built checkbox18 and tested on dawson-i. Looks fine, need to keep an eye on edge runs.

review: Approve
Revision history for this message
Sylvain Pineau (sylvain-pineau) wrote :

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/snap/snapcraft.yaml b/snap/snapcraft.yaml
2index 5042fa9..c6e711e 100644
3--- a/snap/snapcraft.yaml
4+++ b/snap/snapcraft.yaml
5@@ -134,14 +134,14 @@ parts:
6 - build-essential
7 python-packages:
8 - guacamole
9- - Jinja2
10- - padme
11- - requests-oauthlib
12- - urwid
13- - XlsxWriter
14 stage-packages:
15- - sudo
16 - libpam-modules
17+ - python3-jinja2
18+ - python3-padme
19+ - python3-requests-oauthlib
20+ - python3-urwid
21+ - python3-xlsxwriter
22+ - sudo
23 ################################################################################
24 plainbox-provider-resource:
25 source-tag: ""

Subscribers

People subscribed via source and target branches