Merge lp:~sylvain-pineau/cdts/bug1214914 into lp:cdts

Proposed by Sylvain Pineau
Status: Merged
Approved by: Zygmunt Krynicki
Approved revision: 2289
Merged at revision: 2289
Proposed branch: lp:~sylvain-pineau/cdts/bug1214914
Merge into: lp:cdts
Diff against target: 17 lines (+6/-1)
1 file modified
plainbox-gui/gui-engine/gui-engine.cpp (+6/-1)
To merge this branch: bzr merge lp:~sylvain-pineau/cdts/bug1214914
Reviewer Review Type Date Requested Status
Zygmunt Krynicki (community) Approve
Review via email:

Description of the change

A workaround for the linked bug. Use a non native rendering of QFileDialog to avoid the ghost window.

To post a comment you must log in.
Revision history for this message
Zygmunt Krynicki (zyga) wrote :

Looks good to me

review: Approve
Revision history for this message
Andrew Haigh (andrew-haigh-b) wrote :

So simple I cant see any issues as such with the code.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'plainbox-gui/gui-engine/gui-engine.cpp'
--- plainbox-gui/gui-engine/gui-engine.cpp 2013-09-05 12:14:41 +0000
+++ plainbox-gui/gui-engine/gui-engine.cpp 2013-09-06 13:45:13 +0000
@@ -1834,7 +1834,12 @@
1835 QString prompt = "Choose a filename:";1835 QString prompt = "Choose a filename:";
1837 return QFileDialog::getSaveFileName(NULL,prompt, "submission.xml", tr("XML files (*.xml)"));1837 return QFileDialog::getSaveFileName(NULL, \
1838 prompt, \
1839 "submission.xml", \
1840 tr("XML files (*.xml)"), \
1841 NULL, \
1842 QFileDialog::DontUseNativeDialog);
1840const QDBusObjectPath GuiEngine::GetCurrentSession(void)1845const QDBusObjectPath GuiEngine::GetCurrentSession(void)


People subscribed via source and target branches