Canonical Driver Test Suite

Merge lp:~sylvain-pineau/cdts/bug1214914 into lp:cdts

  1. bug1214914
  2. Merge into trunk
Proposed by Sylvain Pineau
Status: Merged
Approved by: Zygmunt Krynicki
Approved revision: 2289
Merged at revision: 2289
Proposed branch: lp:~sylvain-pineau/cdts/bug1214914
Merge into: lp:cdts
Diff against target: 17 lines (+6/-1)
1 file modified
plainbox-gui/gui-engine/gui-engine.cpp (+6/-1)
To merge this branch: bzr merge lp:~sylvain-pineau/cdts/bug1214914
Reviewer Review Type Date Requested Status
Zygmunt Krynicki (community) Approve
Review via email: mp+184305@code.launchpad.net

Description of the change

A workaround for the linked bug. Use a non native rendering of QFileDialog to avoid the ghost window.

To post a comment you must log in.
Revision history for this message
Zygmunt Krynicki (zyga) wrote :

Looks good to me

review: Approve
Revision history for this message
Andrew Haigh (andrew-haigh-b) wrote :

So simple I cant see any issues as such with the code.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'plainbox-gui/gui-engine/gui-engine.cpp'
2--- plainbox-gui/gui-engine/gui-engine.cpp 2013-09-05 12:14:41 +0000
3+++ plainbox-gui/gui-engine/gui-engine.cpp 2013-09-06 13:45:13 +0000
4@@ -1834,7 +1834,12 @@
5 {
6 QString prompt = "Choose a filename:";
7
8- return QFileDialog::getSaveFileName(NULL,prompt, "submission.xml", tr("XML files (*.xml)"));
9+ return QFileDialog::getSaveFileName(NULL, \
10+ prompt, \
11+ "submission.xml", \
12+ tr("XML files (*.xml)"), \
13+ NULL, \
14+ QFileDialog::DontUseNativeDialog);
15 }
16
17 const QDBusObjectPath GuiEngine::GetCurrentSession(void)

Subscribers

People subscribed via source and target branches