Merge lp:~sylvain-legal/openupgrade-addons/migration-analytic into lp:openupgrade-addons

[Sylvain LE GAL (GRAP)]

[ADD] migration scripts for 'analytic' module.

Hi.

[ADD] migration scripts for 'analytic' module.
- pre-migration.py ;
- post-migration.py ("empty")
- openupgrade_analysis_worker.txt. (notes about analysis)

Warning : do not merge before an other branch is merged in an other project (openupgrade-server), because 'pre-migration.py' use get_partner_id_from_partner_address_id() function.

'OpenUpgrade-server' Prerequisite Branch :
(https://code.launchpad.net/~sylvain-legal/openupgrade-server/three-functions-for-addons-migration/+merge/174668)

[Stefan Rijnhart (Opener) (stefan-opener)]

Thanks! Here are my comments,

- The analytic sequences are not new but come from the account module, and need to be renamed here because analytic is a dependency of account.
- 'type' is now required. You may want to replace empty values in the database with the new default 'normal' just to be sure.
- 'manager_id' is set by an onchange method to the partner's salesperson ('user_id'). It would be nice if you could retrieve and store this value for all existing analytic accounts that have a partner_id (in the post script).

Keep up the great work, Sylvain!

review: Needs Fixing

[Sylvain LE GAL (GRAP) (sylvain-legal)]

Thanks for your quick review !

1/ You're right.
--> changed commited.

2/ I'm not sure. To test I did the following :
A : in a 6.1 : "update account_analytic_account set type=null; "
B : migration -> 7.0
C : the 'type' values are 'normal' ; --> OK
A' in a 6.1 : "update account_analytic_account set type='wrong_value'; "
B' : migration -> 7.0
C' : the 'type' value still is 'wrong_value' ; --> FAILED
Conclusion, if the database values are OK, the migration will do the following :
- Null, 'normal' -> 'normal'
- 'view' -> 'view'

3/ You're right too !
--> changed commited.

[Stefan Rijnhart (Opener) (stefan-opener)]

Thanks, you are right on 2: newly required fields with a default value are filled automatically. Approved!

review: Approve

[Stefan Rijnhart (Opener) (stefan-opener)]

Sylvain,

because of your holidays I took the liberty again to refactor your branch to adapt to the API change that I suggested:
https://code.launchpad.net/~therp-nl/openupgrade-addons/migration-analytic/+merge/175796

[Holger Brunn (Therp) (hbrunn)]

approve, but rejecting this MP as it's superseded by Stefan's one

review: Approve

=== added file 'analytic/migrations/7.0.1.1/openupgrade_analysis_worker.txt'
--- analytic/migrations/7.0.1.1/openupgrade_analysis_worker.txt	1970-01-01 00:00:00 +0000
+++ analytic/migrations/7.0.1.1/openupgrade_analysis_worker.txt	2013-07-15 16:52:26 +0000
@@ -0,0 +1,34 @@
+---analytic---
+analytic     / account.analytic.account / contact_id (many2one)         : DEL relation: res.partner.address
+# In 6.1, there is Two field partner_id [res.partner] and contact_id [res.partner.adress]
+# In 7.0, there is on contact_id [res.partner] due to the merging of concept.
+# -> Merging choice : select the old 'contact_id' (more precise) to fill 'partner_id' if 'contact_id' is defined.
+
+analytic     / account.analytic.account / template_id (many2one)        : NEW relation: account.analytic.account
+# --> New concept available only in case of Account_analytic_accont.type="contract" : OK. (because 'contract' is new keys)
+
+analytic     / account.analytic.account / manager_id (many2one)         : NEW relation: res.users
+# --> New concept: OK
+
+analytic     / account.analytic.account / message_ids (one2many)        : NEW relation: mail.message
+# --> New concept: OK 
+
+analytic     / account.analytic.account / type (selection)              : selection_keys is now '['contract', 'normal', 'template', 'view']' ('['normal', 'view']')
+# New keys in selection : OK.
+
+analytic     / account.analytic.account / type (selection)              : now required, default = normal
+# Value is required with default value : OK 
+
+
+new xml-id of model mail.message.subtype: analytic.mt_account_closed    # mail.message.subtype is NEW : OK.
+new xml-id of model mail.message.subtype: analytic.mt_account_opened    # mail.message.subtype is NEW : OK.
+new xml-id of model mail.message.subtype: analytic.mt_account_pending   # mail.message.subtype is NEW : OK.
+
+new xml-id of model ir.sequence.type: analytic.seq_type_analytic_account_main
+### previously in module "account" and named "seq_type_analytic_account". Rename xml : OK
+
+new xml-id of model ir.sequence: analytic.seq_analytic_account_base
+### previously in module "account" and named "seq_analytic_account". Rename xml : OK
+
+### System XML IDs belows : (Nothing to do)
+new xml-id of model ir.ui.view: analytic.view_account_analytic_account_form

=== added file 'analytic/migrations/7.0.1.1/post-migration.py'
--- analytic/migrations/7.0.1.1/post-migration.py	1970-01-01 00:00:00 +0000
+++ analytic/migrations/7.0.1.1/post-migration.py	2013-07-15 16:52:26 +0000
@@ -0,0 +1,64 @@
+# -*- coding: utf-8 -*-
+##############################################################################
+#
+#    OpenERP, Open Source Management Solution
+#    This migration script copyright (C) 2013-today Sylvain LE GAL
+#
+#    This program is free software: you can redistribute it and/or modify
+#    it under the terms of the GNU Affero General Public License as
+#    published by the Free Software Foundation, either version 3 of the
+#    License, or (at your option) any later version.
+#
+#    This program is distributed in the hope that it will be useful,
+#    but WITHOUT ANY WARRANTY; without even the implied warranty of
+#    MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+#    GNU Affero General Public License for more details.
+#
+#    You should have received a copy of the GNU Affero General Public License
+#    along with this program.  If not, see <http://www.gnu.org/licenses/>.
+#
+##############################################################################
+
+from openupgrade import openupgrade
+from openupgrade import openupgrade_70
+from openerp import pooler, SUPERUSER_ID
+
+def migrate_partner_address(cr, pool):
+    """ 
+    Manage partner changes in 'account.analytic.account'.
+    Use obsolete 'contact_id' field to fill 'partner_id' if 'contact_id' is not null.
+    Otherwise, use partner_id.
+    """
+    analytic_obj = pool.get('account.analytic.account')
+    cr.execute("""
+        SELECT id, contact_id
+        FROM account_analytic_account
+        WHERE contact_id is not null; """)
+    for row in cr.dictfetchall():
+        vals = {
+            'partner_id': openupgrade_70.get_partner_id_from_partner_address_id(cr, row['contact_id']),
+            }
+        analytic_obj.write(cr, SUPERUSER_ID, row['id'], vals)
+
+def fill_manager_id(cr, pool): 
+    """
+    Fill the new field 'manager_id' depending on account_analytic_account.partner_id.user_id
+    """
+    analytic_obj = pool.get('account.analytic.account')
+    cr.execute("""SELECT 
+        account_analytic_account.id as id,
+        res_users.id as manager_id
+    FROM account_analytic_account 
+    INNER JOIN res_partner on res_partner.id = account_analytic_account.partner_id
+    INNER JOIN res_users on res_partner.user_id = res_users.id; """)
+    for row in cr.dictfetchall():
+        vals = {
+            'manager_id' : row['manager_id'], 
+        }
+        analytic_obj.write(cr, SUPERUSER_ID, row['id'], vals)
+
[e-mail]()
+def migrate(cr, version):
+    pool = pooler.get_pool(cr.dbname)
+    migrate_partner_address(cr, pool)
+    fill_manager_id(cr, pool)

=== added file 'analytic/migrations/7.0.1.1/pre-migration.py'
--- analytic/migrations/7.0.1.1/pre-migration.py	1970-01-01 00:00:00 +0000
+++ analytic/migrations/7.0.1.1/pre-migration.py	2013-07-15 16:52:26 +0000
@@ -0,0 +1,31 @@
+# -*- coding: utf-8 -*-
+##############################################################################
+#
+#    OpenERP, Open Source Management Solution
+#    This migration script copyright (C) 2013-today Sylvain LE GAL
+#
+#    This program is free software: you can redistribute it and/or modify
+#    it under the terms of the GNU Affero General Public License as
+#    published by the Free Software Foundation, either version 3 of the
+#    License, or (at your option) any later version.
+#
+#    This program is distributed in the hope that it will be useful,
+#    but WITHOUT ANY WARRANTY; without even the implied warranty of
+#    MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+#    GNU Affero General Public License for more details.
+#
+#    You should have received a copy of the GNU Affero General Public License
+#    along with this program.  If not, see <http://www.gnu.org/licenses/>.
+#
+##############################################################################
+
+from openupgrade import openupgrade
+
+xmlid_renames = [
+    ('account.seq_type_analytic_account', 'analytic.seq_type_analytic_account_main'),
+    ('account.seq_analytic_account', 'analytic.seq_analytic_account_base'),
+]
+
[e-mail]()
+def migrate(cr, version):
+    openupgrade.rename_xmlids(cr, xmlid_renames)