Merge lp:~syleam/openobject-library/fix_dash_split_bug into lp:openobject-library/1.0

[Sylvain Garancher]

Fixes the bug on Windows operating system when splitting a path which contains dashes on importcsv script

[Christophe CHAUVET (christophe-chauvet)]

Hi Sylvain

I prefer you use "os.sep" [1] to find the separator from teh operating system

Please fix and resubmit

Regards,

[1] : http://docs.python.org/release/2.6.8/library/os.html?highlight=os#os.sep

review: Disapprove

[Niels Huylebroeck (red15)]

It's worth checking out this function to see if it can properly handle the splitting of paths as well:

http://docs.python.org/release/2.6.8/library/os.path.html#os.path.split

Mind the caveat that paths ending in '/' (or '\') will not produce a tail return value.

Unmerged revisions

107. By Sylvain Garancher on 2012-07-31

[FIX] Fixed dash split bug on directories names under Windows operating system

=== modified file 'example/importcsv.py'
--- example/importcsv.py	2011-11-14 08:46:43 +0000
+++ example/importcsv.py	2012-07-31 14:00:35 +0000
@@ -127,7 +127,7 @@
     """
     Read the file, and launched import_data
     """
-    model = filename.split('/').pop().replace('.csv', '')
+    model = filename.split('/')[-1].split('\\')[-1].replace('.csv', '')
     model = model[model.find('-') + 1:]
     logger.debug('model: %s' % model)
 
@@ -196,7 +196,7 @@
         sys.exit(2)
 
     # recherche du mon de l'objet dans le nom du fichier sans l'extension
-    fn = opts.filename.split('/').pop()
+    fn = opts.filename.split('/')[-1].split('\\')[-1]
     if not fn.endswith('.csv'):
         logger.error('File must have a CSV extension')
         sys.exit(4)