Odoo GTK Client (MOVED TO GITHUB)

Merge lp:~syleam/openobject-client/5.0-fix-tree-order-sequence into lp:openobject-client/5.0

  1. 5.0-fix-tree-order-sequence
  2. Merge into 5.0
Proposed by Christophe CHAUVET
Status: Rejected
Rejected by: Jay Vora (Serpent Consulting Services)
Proposed branch: lp:~syleam/openobject-client/5.0-fix-tree-order-sequence
Merge into: lp:openobject-client/5.0
Diff against target: None lines
To merge this branch: bzr merge lp:~syleam/openobject-client/5.0-fix-tree-order-sequence
Reviewer Review Type Date Requested Status
Jay Vora (Serpent Consulting Services) (community) Disapprove
Review via email: mp+5437@code.launchpad.net
To post a comment you must log in.
Revision history for this message
Jay Vora (Serpent Consulting Services) (jayvora) wrote :

Disapproved : If the list view has the sequence field in list, no other column is sortable.

review: Disapprove

Unmerged revisions

956. By Christophe CHAUVET

[FIX]
 * When object contain a sequence field on tree view, click on column doesn't reorder it

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'bin/widget/view/tree_gtk/parser.py'
2--- bin/widget/view/tree_gtk/parser.py 2009-04-01 09:57:27 +0000
3+++ bin/widget/view/tree_gtk/parser.py 2009-04-10 16:43:27 +0000
4@@ -147,8 +147,8 @@
5 else:
6 width = twidth.get(fields[fname]['type'], 100)
7 col.set_min_width(width)
8- if not treeview.sequence:
9- col.connect('clicked', sort_model, treeview)
10+ #if not treeview.sequence:
11+ col.connect('clicked', sort_model, treeview)
12 col.set_resizable(True)
13 #col.set_sizing(gtk.TREE_VIEW_COLUMN_FIXED)
14 visval = eval(fields[fname].get('invisible', 'False'), {'context':self.screen.context})