Merge lp:~syleam/openobject-addons/5.0-fix-crm_configuration into lp:openobject-addons/5.0

Proposed by Sebastien LANGE - http://www.Syleam.fr
Status: Merged
Merged at revision: 2325
Proposed branch: lp:~syleam/openobject-addons/5.0-fix-crm_configuration
Merge into: lp:openobject-addons/5.0
Diff against target: None lines
To merge this branch: bzr merge lp:~syleam/openobject-addons/5.0-fix-crm_configuration
Reviewer Review Type Date Requested Status
OpenERP Core Team Pending
Review via email: mp+6377@code.launchpad.net
To post a comment you must log in.
Revision history for this message
Jay Vora (Serpent Consulting Services) (jayvora) wrote :

Hello Sebastine,
Tell us why you encoded 32 size for phone and mobile fields?
Are they really neccesary?

If its for a personal usage, we cant commit it.
Thank you for the branch.

Revision history for this message
Fabien (Open ERP) (fp-tinyerp) wrote :

Yes, it's better to not change in 5. But you can apply this proposal to
trunk.
Thanks,

Jay (Open ERP) wrote:
> Hello Sebastine,
> Tell us why you encoded 32 size for phone and mobile fields?
> Are they really neccesary?
>
> If its for a personal usage, we cant commit it.
> Thank you for the branch.

--
Fabien Pinckaers
CEO Tiny - OpenERP Editor
Chaussée de Namur 40
B-1367 Grand-Rosière
Belgium
Phone: +32.81.81.37.00
Fax: +32.81.73.35.01
Web: http://openerp.com

Great Achievements Start With Tiny Investments
   -- Marty, 2005

Revision history for this message
Sebastien LANGE - http://www.Syleam.fr (alnslang) wrote :

In France, the phone number is :
+33 (0) 1 23 45 67 89
or
+33 1 23 45 67 89

So, it's not useable with crm_configuration. For me it's a fonctionnal bug.
And the size in res_partner.address is 64 and base_contact 32. To confirm.

> Yes, it's better to not change in 5. But you can apply this proposal to
> trunk.
> Thanks,
>
> Jay (Open ERP) wrote:
> > Hello Sebastine,
> > Tell us why you encoded 32 size for phone and mobile fields?
> > Are they really neccesary?
> >
> > If its for a personal usage, we cant commit it.
> > Thank you for the branch.
>
>
> --
> Fabien Pinckaers
> CEO Tiny - OpenERP Editor
> Chaussée de Namur 40
> B-1367 Grand-Rosière
> Belgium
> Phone: +32.81.81.37.00
> Fax: +32.81.73.35.01
> Web: http://openerp.com
>
> Great Achievements Start With Tiny Investments
> -- Marty, 2005

Revision history for this message
Fabien (Open ERP) (fp-tinyerp) wrote :

Ok, let's change in branch/5 too.

Sebastien LANGE - http://www.Syleam.fr wrote:
> In France, the phone number is :
> +33 (0) 1 23 45 67 89
> or
> +33 1 23 45 67 89
>
> So, it's not useable with crm_configuration. For me it's a fonctionnal bug.
> And the size in res_partner.address is 64 and base_contact 32. To confirm.
>
>
>> Yes, it's better to not change in 5. But you can apply this proposal to
>> trunk.
>> Thanks,
>>
>> Jay (Open ERP) wrote:
>>> Hello Sebastine,
>>> Tell us why you encoded 32 size for phone and mobile fields?
>>> Are they really neccesary?
>>>
>>> If its for a personal usage, we cant commit it.
>>> Thank you for the branch.
>>
>> --
>> Fabien Pinckaers
>> CEO Tiny - OpenERP Editor
>> Chaussée de Namur 40
>> B-1367 Grand-Rosière
>> Belgium
>> Phone: +32.81.81.37.00
>> Fax: +32.81.73.35.01
>> Web: http://openerp.com
>>
>> Great Achievements Start With Tiny Investments
>> -- Marty, 2005

--
Fabien Pinckaers
CEO Tiny - OpenERP Editor
Chaussée de Namur 40
B-1367 Grand-Rosière
Belgium
Phone: +32.81.81.37.00
Fax: +32.81.73.35.01
Web: http://openerp.com

Great Achievements Start With Tiny Investments
   -- Marty, 2005

Revision history for this message
Jay Vora (Serpent Consulting Services) (jayvora) wrote :

Changes Applied.
Thanks.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'crm_configuration/crm_config.py'
2--- crm_configuration/crm_config.py 2009-03-31 12:17:20 +0000
3+++ crm_configuration/crm_config.py 2009-05-09 17:44:46 +0000
4@@ -71,8 +71,8 @@
5 'case_id': fields.many2one('crm.case','Related Case'),
6 'partner_name': fields.char('Employee Name', size=64),
7 'partner_name2': fields.char('Employee Email', size=64),
8- 'partner_phone': fields.char('Phone', size=16),
9- 'partner_mobile': fields.char('Mobile', size=16),
10+ 'partner_phone': fields.char('Phone', size=32),
11+ 'partner_mobile': fields.char('Mobile', size=32),
12 }
13 def stage_next(self, cr, uid, ids, context={}):
14 ok = False
15
16=== modified file 'crm_configuration/crm_lead_demo.xml'
17--- crm_configuration/crm_lead_demo.xml 2008-11-02 15:53:39 +0000
18+++ crm_configuration/crm_lead_demo.xml 2009-05-09 17:45:26 +0000
19@@ -16,7 +16,7 @@
20 <field eval="&quot;Michel Lafont&quot;" name="partner_name2"/>
21 <field eval="&quot;(726) 782-0636&quot;" name="partner_mobile"/>
22 <field eval="1" name="active"/>
23- <field name="categ_id" ref="crm_configuration.category_lead5"/>
24+ <field name="categ_id" ref="crm_configuration.categ_lead6"/>
25 <field name="stage_id" ref="crm_configuration.stage_lead1"/>
26 <field eval="&quot;The Oil Company&quot;" name="partner_name"/>
27 <field eval="&quot;(769) 703-274&quot;" name="partner_phone"/>