Merge ~swem/ubiquity/+git/ubiquity:lp1772374.bionic into ubiquity:bionic

Proposed by Chen-Han Hsiao (Stanley) on 2018-05-23
Status: Merged
Approved by: Mathieu Trudel-Lapierre on 2019-01-31
Approved revision: 5b4db4c371f0b7bc580c9195aaa25ed145493910
Merged at revision: 389864b074f7345be24d014cf52d47626ede2e2f
Proposed branch: ~swem/ubiquity/+git/ubiquity:lp1772374.bionic
Merge into: ubiquity:bionic
Diff against target: 13 lines (+2/-1)
1 file modified
scripts/ (+2/-1)
Reviewer Review Type Date Requested Status
Drew Walton (community) Approve on 2019-01-03
Mathieu Trudel-Lapierre 2018-06-26 Pending
Ubuntu Installer Team 2018-05-23 Pending
Review via email:
To post a comment you must log in.
Chen-Han Hsiao (Stanley) (swem) wrote :

Hi, cyphermox

Could you help to take a look on the patch for ubiquity 18.04? Thanks!.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/scripts/ b/scripts/
2index 70c3aa9..25b30b3 100755
3--- a/scripts/
4+++ b/scripts/
5@@ -954,7 +954,8 @@ class Install(install_misc.InstallBase):
7 inst_boot = self.db.get('ubiquity/install_bootloader')
8 if inst_boot == 'true' and 'UBIQUITY_NO_BOOTLOADER' not in os.environ:
9- binds = ("/proc", "/sys", "/dev", "/run")
10+ binds = ("/proc", "/sys", "/dev", "/run",
11+ "/sys/firmware/efi/efivars")
12 for bind in binds:
13 misc.execute('mount', '--bind', bind, + bind)


People subscribed via source and target branches