Merge lp:~suutari-olli/openlp/rename_Powerpoint_to_PowerPoint into lp:openlp

Proposed by Azaziah
Status: Needs review
Proposed branch: lp:~suutari-olli/openlp/rename_Powerpoint_to_PowerPoint
Merge into: lp:openlp
Diff against target: 912 lines (+123/-123)
39 files modified
openlp/plugins/presentations/lib/mediaitem.py (+1/-1)
openlp/plugins/presentations/lib/powerpointcontroller.py (+10/-10)
openlp/plugins/presentations/lib/pptviewcontroller.py (+1/-1)
openlp/plugins/presentations/lib/presentationcontroller.py (+1/-1)
openlp/plugins/presentations/lib/presentationtab.py (+2/-2)
openlp/plugins/presentations/presentationplugin.py (+2/-2)
openlp/plugins/songs/lib/importers/openoffice.py (+1/-1)
resources/i18n/af.ts (+2/-2)
resources/i18n/bg.ts (+2/-2)
resources/i18n/cs.ts (+3/-3)
resources/i18n/da.ts (+3/-3)
resources/i18n/de.ts (+3/-3)
resources/i18n/el.ts (+2/-2)
resources/i18n/en.ts (+3/-3)
resources/i18n/en_GB.ts (+3/-3)
resources/i18n/en_ZA.ts (+3/-3)
resources/i18n/es.ts (+2/-2)
resources/i18n/et.ts (+3/-3)
resources/i18n/fi.ts (+3/-3)
resources/i18n/fr.ts (+2/-2)
resources/i18n/hu.ts (+3/-3)
resources/i18n/id.ts (+2/-2)
resources/i18n/ja.ts (+2/-2)
resources/i18n/ko.ts (+2/-2)
resources/i18n/lt.ts (+3/-3)
resources/i18n/nb.ts (+3/-3)
resources/i18n/nl.ts (+4/-4)
resources/i18n/pl.ts (+3/-3)
resources/i18n/pt_BR.ts (+2/-2)
resources/i18n/ru.ts (+2/-2)
resources/i18n/sk.ts (+3/-3)
resources/i18n/sv.ts (+3/-3)
resources/i18n/ta_LK.ts (+2/-2)
resources/i18n/th_TH.ts (+2/-2)
resources/i18n/zh_CN.ts (+2/-2)
resources/i18n/zh_TW.ts (+3/-3)
tests/functional/openlp_plugins/presentations/test_mediaitem.py (+2/-2)
tests/functional/openlp_plugins/presentations/test_powerpointcontroller.py (+24/-24)
tests/functional/openlp_plugins/presentations/test_pptviewcontroller.py (+4/-4)
To merge this branch: bzr merge lp:~suutari-olli/openlp/rename_Powerpoint_to_PowerPoint
Reviewer Review Type Date Requested Status
Tim Bentley Disapprove
Review via email: mp+277238@code.launchpad.net

Description of the change

At the moment PowerPoint is called as Powerpoint in the UI.

This branch renames all occurrences of "Powerpoint" to "PowerPoint"
The all small "powerpoint" is left un-touched.
Nothing else is changed in this branch.
Total count of replaced "Powerpoint" in text editor: 126

https://ci.openlp.io/view/Branch/job/Branch-05b-Test_Coverage/470/console

To post a comment you must log in.
Revision history for this message
Tim Bentley (trb143) wrote :

This request is incorrect on many fronts.
Though as you say we have spelt Powerpoint wrong most of the cases are internal.
We spent a year refactoring the code to change and fix the names style and have a standard which we adhere to.
The only external change would be 76 the error message all the rest are internal.
Please note that you cannot change translations they need to be done via Transifex and now you are asked 30 people to change the string.

On a side note this patch has a number of other failings.
- You cannot rename settings without adding a settings migration,
- You have no new tests.
- You have not run and proved you have run the Jenkins test suite.

review: Disapprove
Revision history for this message
Azaziah (suutari-olli) wrote :

Thanks for the review trb143,

however, you have clearly have missed some things and leave a few questions:
First of all, this also changes how PowerPoint is called in list of presentation
controllers. This includes both Powerpoint and Powerpoint viewer.

These are un-translatable and come directly from some part of the code which
includes “Powerpoint”. If we change “Powerpoint” from one function but leave
the other “Internals” in-touched, changes are something gets broken. If we are
going to start PowerPoint with big P, we should always bring along the 2nd the
way. While capitalizing the 1st letter seems okayish standard normally, I
think we shouldn’t do it with PowerPoint.

Translations: Really? Can’t we just backup the translations
for the current string and re-place the new one with the old ones.
(With the big P fix). This shouldn’t be too much work for one person,
if it comes to that – I’d gladly do it.

Settings migration: If something was called
“Powerpoint” it is now called: “PowerPoint”
New tests: If something was called “Powerpoint”
it is now called: “PowerPoint”

Jenkins: Please re-read the description, it clearly includes
link to Jenkins test suite. You should be able to open the other
tests from the last one easily.

As stated before, this branch only renames
Powerpoint to PowerPoint everywhere,
if the i18n strings are a problem,
I can leave them out from the branch.

What kind of tests are you perhaps hoping to see with this change?
What do you mean with setting migration?

Revision history for this message
Tim Bentley (trb143) wrote :

1) It does not matter if you think you got all the changes it increases potential instability in code. We have been there are it is a risk for no gain.

2) Internal names do not matter, external ones do and that is why changing the Message may help.

3) The names are used internally and compared to drive processes, this is brittle but works and you plan to change it.

4) Jenkins we need to complete run not just a bit of it. How do I know you did not break the tests.

5) Any test to increase test coverage.

6) if you change a setting then you need to make sure the value is preserved across the change. Look in settings.py there is an example of a change from songs to advanced.

All this said this will not be going in so please do not resubmit, Please can you help and find some bugs and features to add and the tak this project forward. Your effort is appreciated but chaning things for change sake is not going to help.

Unmerged revisions

2567. By Azaziah

At the moment PowerPoint is shown as Powerpoint in OLP ui.
This branch renames Powerpoint to PowerPoint in all files.
Total occurances replaced: 126
The all small powerpoint is left un-touched.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'openlp/plugins/presentations/lib/mediaitem.py'
--- openlp/plugins/presentations/lib/mediaitem.py 2015-06-02 21:13:15 +0000
+++ openlp/plugins/presentations/lib/mediaitem.py 2015-11-11 12:38:06 +0000
@@ -42,7 +42,7 @@
42class PresentationMediaItem(MediaManagerItem):42class PresentationMediaItem(MediaManagerItem):
43 """43 """
44 This is the Presentation media manager item for Presentation Items. It can present files using Openoffice and44 This is the Presentation media manager item for Presentation Items. It can present files using Openoffice and
45 Powerpoint45 PowerPoint
46 """46 """
47 log.info('Presentations Media Item loaded')47 log.info('Presentations Media Item loaded')
4848
4949
=== modified file 'openlp/plugins/presentations/lib/powerpointcontroller.py'
--- openlp/plugins/presentations/lib/powerpointcontroller.py 2015-06-16 07:47:42 +0000
+++ openlp/plugins/presentations/lib/powerpointcontroller.py 2015-11-11 12:38:06 +0000
@@ -48,19 +48,19 @@
48log = logging.getLogger(__name__)48log = logging.getLogger(__name__)
4949
5050
51class PowerpointController(PresentationController):51class PowerPointController(PresentationController):
52 """52 """
53 Class to control interactions with PowerPoint Presentations. It creates the runtime Environment , Loads the and53 Class to control interactions with PowerPoint Presentations. It creates the runtime Environment , Loads the and
54 Closes the Presentation. As well as triggering the correct activities based on the users input.54 Closes the Presentation. As well as triggering the correct activities based on the users input.
55 """55 """
56 log.info('PowerpointController loaded')56 log.info('PowerPointController loaded')
5757
58 def __init__(self, plugin):58 def __init__(self, plugin):
59 """59 """
60 Initialise the class60 Initialise the class
61 """61 """
62 log.debug('Initialising')62 log.debug('Initialising')
63 super(PowerpointController, self).__init__(plugin, 'Powerpoint', PowerpointDocument)63 super(PowerPointController, self).__init__(plugin, 'PowerPoint', PowerPointDocument)
64 self.supports = ['ppt', 'pps', 'pptx', 'ppsx', 'pptm']64 self.supports = ['ppt', 'pps', 'pptx', 'ppsx', 'pptm']
65 self.process = None65 self.process = None
6666
@@ -116,7 +116,7 @@
116 self.process = None116 self.process = None
117117
118118
119class PowerpointDocument(PresentationDocument):119class PowerPointDocument(PresentationDocument):
120 """120 """
121 Class which holds information and controls a single presentation.121 Class which holds information and controls a single presentation.
122 """122 """
@@ -128,8 +128,8 @@
128 :param controller:128 :param controller:
129 :param presentation:129 :param presentation:
130 """130 """
131 log.debug('Init Presentation Powerpoint')131 log.debug('Init Presentation PowerPoint')
132 super(PowerpointDocument, self).__init__(controller, presentation)132 super(PowerPointDocument, self).__init__(controller, presentation)
133 self.presentation = None133 self.presentation = None
134 self.index_map = {}134 self.index_map = {}
135 self.slide_count = 0135 self.slide_count = 0
@@ -155,7 +155,7 @@
155 Registry().get('main_window').activateWindow()155 Registry().get('main_window').activateWindow()
156 return True156 return True
157 except (AttributeError, pywintypes.com_error) as e:157 except (AttributeError, pywintypes.com_error) as e:
158 log.exception('Exception caught while loading Powerpoint presentation')158 log.exception('Exception caught while loading PowerPoint presentation')
159 log.exception(e)159 log.exception(e)
160 trace_error_handler(log)160 trace_error_handler(log)
161 return False161 return False
@@ -511,10 +511,10 @@
511 try:511 try:
512 self.presentation.SlideShowWindow.View.Exit()512 self.presentation.SlideShowWindow.View.Exit()
513 except (AttributeError, pywintypes.com_error) as e:513 except (AttributeError, pywintypes.com_error) as e:
514 log.exception('Failed to exit Powerpoint presentation after error')514 log.exception('Failed to exit PowerPoint presentation after error')
515 log.exception(e)515 log.exception(e)
516 critical_error_message_box(UiStrings().Error, translate('PresentationPlugin.PowerpointDocument',516 critical_error_message_box(UiStrings().Error, translate('PresentationPlugin.PowerPointDocument',
517 'An error occurred in the Powerpoint integration '517 'An error occurred in the PowerPoint integration '
518 'and the presentation will be stopped. '518 'and the presentation will be stopped. '
519 'Restart the presentation if you wish to present it.'))519 'Restart the presentation if you wish to present it.'))
520520
521521
=== modified file 'openlp/plugins/presentations/lib/pptviewcontroller.py'
--- openlp/plugins/presentations/lib/pptviewcontroller.py 2015-01-18 13:39:21 +0000
+++ openlp/plugins/presentations/lib/pptviewcontroller.py 2015-11-11 12:38:06 +0000
@@ -55,7 +55,7 @@
55 """55 """
56 log.debug('Initialising')56 log.debug('Initialising')
57 self.process = None57 self.process = None
58 super(PptviewController, self).__init__(plugin, 'Powerpoint Viewer', PptviewDocument)58 super(PptviewController, self).__init__(plugin, 'PowerPoint Viewer', PptviewDocument)
59 self.supports = ['ppt', 'pps', 'pptx', 'ppsx', 'pptm']59 self.supports = ['ppt', 'pps', 'pptx', 'ppsx', 'pptm']
6060
61 def check_available(self):61 def check_available(self):
6262
=== modified file 'openlp/plugins/presentations/lib/presentationcontroller.py'
--- openlp/plugins/presentations/lib/presentationcontroller.py 2015-03-09 21:39:31 +0000
+++ openlp/plugins/presentations/lib/presentationcontroller.py 2015-11-11 12:38:06 +0000
@@ -352,7 +352,7 @@
352 ``__init__``, ``check_available`` and ``presentation_deleted`` should always be implemented.352 ``__init__``, ``check_available`` and ``presentation_deleted`` should always be implemented.
353353
354 See :class:`~openlp.plugins.presentations.lib.impresscontroller.ImpressController`,354 See :class:`~openlp.plugins.presentations.lib.impresscontroller.ImpressController`,
355 :class:`~openlp.plugins.presentations.lib.powerpointcontroller.PowerpointController` or355 :class:`~openlp.plugins.presentations.lib.powerpointcontroller.PowerPointController` or
356 :class:`~openlp.plugins.presentations.lib.pptviewcontroller.PptviewController`356 :class:`~openlp.plugins.presentations.lib.pptviewcontroller.PptviewController`
357 for examples.357 for examples.
358358
359359
=== modified file 'openlp/plugins/presentations/lib/presentationtab.py'
--- openlp/plugins/presentations/lib/presentationtab.py 2015-06-02 21:16:10 +0000
+++ openlp/plugins/presentations/lib/presentationtab.py 2015-11-11 12:38:06 +0000
@@ -148,10 +148,10 @@
148 controller = self.controllers[key]148 controller = self.controllers[key]
149 checkbox = self.presenter_check_boxes[controller.name]149 checkbox = self.presenter_check_boxes[controller.name]
150 checkbox.setChecked(Settings().value(self.settings_section + '/' + controller.name))150 checkbox.setChecked(Settings().value(self.settings_section + '/' + controller.name))
151 if controller.name == 'Powerpoint' and controller.is_available():151 if controller.name == 'PowerPoint' and controller.is_available():
152 powerpoint_available = True152 powerpoint_available = True
153 self.override_app_check_box.setChecked(Settings().value(self.settings_section + '/override app'))153 self.override_app_check_box.setChecked(Settings().value(self.settings_section + '/override app'))
154 # Load Powerpoint settings154 # Load PowerPoint settings
155 self.ppt_slide_click_check_box.setChecked(Settings().value(self.settings_section +155 self.ppt_slide_click_check_box.setChecked(Settings().value(self.settings_section +
156 '/powerpoint slide click advance'))156 '/powerpoint slide click advance'))
157 self.ppt_slide_click_check_box.setEnabled(powerpoint_available)157 self.ppt_slide_click_check_box.setEnabled(powerpoint_available)
158158
=== modified file 'openlp/plugins/presentations/presentationplugin.py'
--- openlp/plugins/presentations/presentationplugin.py 2015-10-16 16:49:58 +0000
+++ openlp/plugins/presentations/presentationplugin.py 2015-11-11 12:38:06 +0000
@@ -40,8 +40,8 @@
40 'presentations/enable_pdf_program': QtCore.Qt.Unchecked,40 'presentations/enable_pdf_program': QtCore.Qt.Unchecked,
41 'presentations/pdf_program': '',41 'presentations/pdf_program': '',
42 'presentations/Impress': QtCore.Qt.Checked,42 'presentations/Impress': QtCore.Qt.Checked,
43 'presentations/Powerpoint': QtCore.Qt.Checked,43 'presentations/PowerPoint': QtCore.Qt.Checked,
44 'presentations/Powerpoint Viewer': QtCore.Qt.Checked,44 'presentations/PowerPoint Viewer': QtCore.Qt.Checked,
45 'presentations/Pdf': QtCore.Qt.Checked,45 'presentations/Pdf': QtCore.Qt.Checked,
46 'presentations/presentations files': [],46 'presentations/presentations files': [],
47 'presentations/thumbnail_scheme': '',47 'presentations/thumbnail_scheme': '',
4848
=== modified file 'openlp/plugins/songs/lib/importers/openoffice.py'
--- openlp/plugins/songs/lib/importers/openoffice.py 2015-08-28 10:22:06 +0000
+++ openlp/plugins/songs/lib/importers/openoffice.py 2015-11-11 12:38:06 +0000
@@ -49,7 +49,7 @@
4949
50class OpenOfficeImport(SongImport):50class OpenOfficeImport(SongImport):
51 """51 """
52 Import songs from Impress/Powerpoint docs using Impress52 Import songs from Impress/PowerPoint docs using Impress
53 """53 """
54 def __init__(self, manager, **kwargs):54 def __init__(self, manager, **kwargs):
55 """55 """
5656
=== modified file 'resources/i18n/af.ts'
--- resources/i18n/af.ts 2015-10-15 16:55:00 +0000
+++ resources/i18n/af.ts 2015-11-11 12:38:06 +0000
@@ -7604,10 +7604,10 @@
7604 </message>7604 </message>
7605</context>7605</context>
7606<context>7606<context>
7607 <name>PresentationPlugin.PowerpointDocument</name>7607 <name>PresentationPlugin.PowerPointDocument</name>
7608 <message>7608 <message>
7609 <location filename="openlp/plugins/presentations/lib/powerpointcontroller.py" line="517"/>7609 <location filename="openlp/plugins/presentations/lib/powerpointcontroller.py" line="517"/>
7610 <source>An error occurred in the Powerpoint integration and the presentation will be stopped. Restart the presentation if you wish to present it.</source>7610 <source>An error occurred in the PowerPoint integration and the presentation will be stopped. Restart the presentation if you wish to present it.</source>
7611 <translation type="unfinished"/>7611 <translation type="unfinished"/>
7612 </message>7612 </message>
7613</context>7613</context>
76147614
=== modified file 'resources/i18n/bg.ts'
--- resources/i18n/bg.ts 2015-10-15 16:55:00 +0000
+++ resources/i18n/bg.ts 2015-11-11 12:38:06 +0000
@@ -7565,10 +7565,10 @@
7565 </message>7565 </message>
7566</context>7566</context>
7567<context>7567<context>
7568 <name>PresentationPlugin.PowerpointDocument</name>7568 <name>PresentationPlugin.PowerPointDocument</name>
7569 <message>7569 <message>
7570 <location filename="openlp/plugins/presentations/lib/powerpointcontroller.py" line="517"/>7570 <location filename="openlp/plugins/presentations/lib/powerpointcontroller.py" line="517"/>
7571 <source>An error occurred in the Powerpoint integration and the presentation will be stopped. Restart the presentation if you wish to present it.</source>7571 <source>An error occurred in the PowerPoint integration and the presentation will be stopped. Restart the presentation if you wish to present it.</source>
7572 <translation type="unfinished"/>7572 <translation type="unfinished"/>
7573 </message>7573 </message>
7574</context>7574</context>
75757575
=== modified file 'resources/i18n/cs.ts'
--- resources/i18n/cs.ts 2015-10-15 16:55:00 +0000
+++ resources/i18n/cs.ts 2015-11-11 12:38:06 +0000
@@ -7708,11 +7708,11 @@
7708 </message>7708 </message>
7709</context>7709</context>
7710<context>7710<context>
7711 <name>PresentationPlugin.PowerpointDocument</name>7711 <name>PresentationPlugin.PowerPointDocument</name>
7712 <message>7712 <message>
7713 <location filename="openlp/plugins/presentations/lib/powerpointcontroller.py" line="517"/>7713 <location filename="openlp/plugins/presentations/lib/powerpointcontroller.py" line="517"/>
7714 <source>An error occurred in the Powerpoint integration and the presentation will be stopped. Restart the presentation if you wish to present it.</source>7714 <source>An error occurred in the PowerPoint integration and the presentation will be stopped. Restart the presentation if you wish to present it.</source>
7715 <translation>Vznikla chyba se začlenění Powerpoint prezentace a prezentace bude zastavena. Pokud si přejete prezentaci zobrazit, spusťte ji znovu.</translation>7715 <translation>Vznikla chyba se začlenění PowerPoint prezentace a prezentace bude zastavena. Pokud si přejete prezentaci zobrazit, spusťte ji znovu.</translation>
7716 </message>7716 </message>
7717</context>7717</context>
7718<context>7718<context>
77197719
=== modified file 'resources/i18n/da.ts'
--- resources/i18n/da.ts 2015-10-15 16:55:00 +0000
+++ resources/i18n/da.ts 2015-11-11 12:38:06 +0000
@@ -7712,11 +7712,11 @@
7712 </message>7712 </message>
7713</context>7713</context>
7714<context>7714<context>
7715 <name>PresentationPlugin.PowerpointDocument</name>7715 <name>PresentationPlugin.PowerPointDocument</name>
7716 <message>7716 <message>
7717 <location filename="openlp/plugins/presentations/lib/powerpointcontroller.py" line="517"/>7717 <location filename="openlp/plugins/presentations/lib/powerpointcontroller.py" line="517"/>
7718 <source>An error occurred in the Powerpoint integration and the presentation will be stopped. Restart the presentation if you wish to present it.</source>7718 <source>An error occurred in the PowerPoint integration and the presentation will be stopped. Restart the presentation if you wish to present it.</source>
7719 <translation>Der opstod en fejl i Powerpoint-integrationen og presentationen vil blive stoppet. Start presentationen igen hvis du vil vise den.</translation>7719 <translation>Der opstod en fejl i PowerPoint-integrationen og presentationen vil blive stoppet. Start presentationen igen hvis du vil vise den.</translation>
7720 </message>7720 </message>
7721</context>7721</context>
7722<context>7722<context>
77237723
=== modified file 'resources/i18n/de.ts'
--- resources/i18n/de.ts 2015-10-15 16:55:00 +0000
+++ resources/i18n/de.ts 2015-11-11 12:38:06 +0000
@@ -7680,11 +7680,11 @@
7680 </message>7680 </message>
7681</context>7681</context>
7682<context>7682<context>
7683 <name>PresentationPlugin.PowerpointDocument</name>7683 <name>PresentationPlugin.PowerPointDocument</name>
7684 <message>7684 <message>
7685 <location filename="openlp/plugins/presentations/lib/powerpointcontroller.py" line="517"/>7685 <location filename="openlp/plugins/presentations/lib/powerpointcontroller.py" line="517"/>
7686 <source>An error occurred in the Powerpoint integration and the presentation will be stopped. Restart the presentation if you wish to present it.</source>7686 <source>An error occurred in the PowerPoint integration and the presentation will be stopped. Restart the presentation if you wish to present it.</source>
7687 <translation>Ein Fehler in der Powerpoint Integration ist aufgetreten und die Präsentation wird nun gestoppt. Um die Präsentation zu zeigen, muss diese neu gestartet werden.</translation>7687 <translation>Ein Fehler in der PowerPoint Integration ist aufgetreten und die Präsentation wird nun gestoppt. Um die Präsentation zu zeigen, muss diese neu gestartet werden.</translation>
7688 </message>7688 </message>
7689</context>7689</context>
7690<context>7690<context>
76917691
=== modified file 'resources/i18n/el.ts'
--- resources/i18n/el.ts 2015-10-15 16:55:00 +0000
+++ resources/i18n/el.ts 2015-11-11 12:38:06 +0000
@@ -7607,10 +7607,10 @@
7607 </message>7607 </message>
7608</context>7608</context>
7609<context>7609<context>
7610 <name>PresentationPlugin.PowerpointDocument</name>7610 <name>PresentationPlugin.PowerPointDocument</name>
7611 <message>7611 <message>
7612 <location filename="openlp/plugins/presentations/lib/powerpointcontroller.py" line="517"/>7612 <location filename="openlp/plugins/presentations/lib/powerpointcontroller.py" line="517"/>
7613 <source>An error occurred in the Powerpoint integration and the presentation will be stopped. Restart the presentation if you wish to present it.</source>7613 <source>An error occurred in the PowerPoint integration and the presentation will be stopped. Restart the presentation if you wish to present it.</source>
7614 <translation type="unfinished"/>7614 <translation type="unfinished"/>
7615 </message>7615 </message>
7616</context>7616</context>
76177617
=== modified file 'resources/i18n/en.ts'
--- resources/i18n/en.ts 2015-10-15 17:34:42 +0000
+++ resources/i18n/en.ts 2015-11-11 12:38:06 +0000
@@ -7710,11 +7710,11 @@
7710 </message>7710 </message>
7711</context>7711</context>
7712<context>7712<context>
7713 <name>PresentationPlugin.PowerpointDocument</name>7713 <name>PresentationPlugin.PowerPointDocument</name>
7714 <message>7714 <message>
7715 <location filename="openlp/plugins/presentations/lib/powerpointcontroller.py" line="517"/>7715 <location filename="openlp/plugins/presentations/lib/powerpointcontroller.py" line="517"/>
7716 <source>An error occurred in the Powerpoint integration and the presentation will be stopped. Restart the presentation if you wish to present it.</source>7716 <source>An error occurred in the PowerPoint integration and the presentation will be stopped. Restart the presentation if you wish to present it.</source>
7717 <translation>An error occurred in the Powerpoint integration and the presentation will be stopped. Restart the presentation if you wish to present it.</translation>7717 <translation>An error occurred in the PowerPoint integration and the presentation will be stopped. Restart the presentation if you wish to present it.</translation>
7718 </message>7718 </message>
7719</context>7719</context>
7720<context>7720<context>
77217721
=== modified file 'resources/i18n/en_GB.ts'
--- resources/i18n/en_GB.ts 2015-10-15 16:55:00 +0000
+++ resources/i18n/en_GB.ts 2015-11-11 12:38:06 +0000
@@ -7709,11 +7709,11 @@
7709 </message>7709 </message>
7710</context>7710</context>
7711<context>7711<context>
7712 <name>PresentationPlugin.PowerpointDocument</name>7712 <name>PresentationPlugin.PowerPointDocument</name>
7713 <message>7713 <message>
7714 <location filename="openlp/plugins/presentations/lib/powerpointcontroller.py" line="517"/>7714 <location filename="openlp/plugins/presentations/lib/powerpointcontroller.py" line="517"/>
7715 <source>An error occurred in the Powerpoint integration and the presentation will be stopped. Restart the presentation if you wish to present it.</source>7715 <source>An error occurred in the PowerPoint integration and the presentation will be stopped. Restart the presentation if you wish to present it.</source>
7716 <translation>An error occurred in the Powerpoint integration and the presentation will be stopped. Restart the presentation if you wish to present it.</translation>7716 <translation>An error occurred in the PowerPoint integration and the presentation will be stopped. Restart the presentation if you wish to present it.</translation>
7717 </message>7717 </message>
7718</context>7718</context>
7719<context>7719<context>
77207720
=== modified file 'resources/i18n/en_ZA.ts'
--- resources/i18n/en_ZA.ts 2015-10-15 16:55:00 +0000
+++ resources/i18n/en_ZA.ts 2015-11-11 12:38:06 +0000
@@ -7710,11 +7710,11 @@
7710 </message>7710 </message>
7711</context>7711</context>
7712<context>7712<context>
7713 <name>PresentationPlugin.PowerpointDocument</name>7713 <name>PresentationPlugin.PowerPointDocument</name>
7714 <message>7714 <message>
7715 <location filename="openlp/plugins/presentations/lib/powerpointcontroller.py" line="517"/>7715 <location filename="openlp/plugins/presentations/lib/powerpointcontroller.py" line="517"/>
7716 <source>An error occurred in the Powerpoint integration and the presentation will be stopped. Restart the presentation if you wish to present it.</source>7716 <source>An error occurred in the PowerPoint integration and the presentation will be stopped. Restart the presentation if you wish to present it.</source>
7717 <translation>An error occurred in the Powerpoint integration and the presentation will be stopped. Restart the presentation if you wish to present it.</translation>7717 <translation>An error occurred in the PowerPoint integration and the presentation will be stopped. Restart the presentation if you wish to present it.</translation>
7718 </message>7718 </message>
7719</context>7719</context>
7720<context>7720<context>
77217721
=== modified file 'resources/i18n/es.ts'
--- resources/i18n/es.ts 2015-10-15 16:55:00 +0000
+++ resources/i18n/es.ts 2015-11-11 12:38:06 +0000
@@ -7712,10 +7712,10 @@
7712 </message>7712 </message>
7713</context>7713</context>
7714<context>7714<context>
7715 <name>PresentationPlugin.PowerpointDocument</name>7715 <name>PresentationPlugin.PowerPointDocument</name>
7716 <message>7716 <message>
7717 <location filename="openlp/plugins/presentations/lib/powerpointcontroller.py" line="517"/>7717 <location filename="openlp/plugins/presentations/lib/powerpointcontroller.py" line="517"/>
7718 <source>An error occurred in the Powerpoint integration and the presentation will be stopped. Restart the presentation if you wish to present it.</source>7718 <source>An error occurred in the PowerPoint integration and the presentation will be stopped. Restart the presentation if you wish to present it.</source>
7719 <translation>Se produjo un error con la integración de PowerPoint y se cerrará la presentación. Reinicie la presentación para mostrarla de nuevo.</translation>7719 <translation>Se produjo un error con la integración de PowerPoint y se cerrará la presentación. Reinicie la presentación para mostrarla de nuevo.</translation>
7720 </message>7720 </message>
7721</context>7721</context>
77227722
=== modified file 'resources/i18n/et.ts'
--- resources/i18n/et.ts 2015-10-15 16:55:00 +0000
+++ resources/i18n/et.ts 2015-11-11 12:38:06 +0000
@@ -7709,11 +7709,11 @@
7709 </message>7709 </message>
7710</context>7710</context>
7711<context>7711<context>
7712 <name>PresentationPlugin.PowerpointDocument</name>7712 <name>PresentationPlugin.PowerPointDocument</name>
7713 <message>7713 <message>
7714 <location filename="openlp/plugins/presentations/lib/powerpointcontroller.py" line="517"/>7714 <location filename="openlp/plugins/presentations/lib/powerpointcontroller.py" line="517"/>
7715 <source>An error occurred in the Powerpoint integration and the presentation will be stopped. Restart the presentation if you wish to present it.</source>7715 <source>An error occurred in the PowerPoint integration and the presentation will be stopped. Restart the presentation if you wish to present it.</source>
7716 <translation>Powerpointi integratsioonil esines viga ja esitlus jääb pooleli. Alusta esitlust uuesti, kui sa siiski tahad seda näidata.</translation>7716 <translation>PowerPointi integratsioonil esines viga ja esitlus jääb pooleli. Alusta esitlust uuesti, kui sa siiski tahad seda näidata.</translation>
7717 </message>7717 </message>
7718</context>7718</context>
7719<context>7719<context>
77207720
=== modified file 'resources/i18n/fi.ts'
--- resources/i18n/fi.ts 2015-10-15 16:55:00 +0000
+++ resources/i18n/fi.ts 2015-11-11 12:38:06 +0000
@@ -7849,11 +7849,11 @@
7849 </message>7849 </message>
7850</context>7850</context>
7851<context>7851<context>
7852 <name>PresentationPlugin.PowerpointDocument</name>7852 <name>PresentationPlugin.PowerPointDocument</name>
7853 <message>7853 <message>
7854 <location filename="openlp/plugins/presentations/lib/powerpointcontroller.py" line="517"/>7854 <location filename="openlp/plugins/presentations/lib/powerpointcontroller.py" line="517"/>
7855 <source>An error occurred in the Powerpoint integration and the presentation will be stopped. Restart the presentation if you wish to present it.</source>7855 <source>An error occurred in the PowerPoint integration and the presentation will be stopped. Restart the presentation if you wish to present it.</source>
7856 <translation>Tapahtui virhe Powerpoint integraatiossa ja esitys keskeytettiin. Käynnistä esitys uudellee, jos tahdot esittää sen.</translation>7856 <translation>Tapahtui virhe PowerPoint integraatiossa ja esitys keskeytettiin. Käynnistä esitys uudellee, jos tahdot esittää sen.</translation>
7857 </message>7857 </message>
7858</context>7858</context>
7859<context>7859<context>
78607860
=== modified file 'resources/i18n/fr.ts'
--- resources/i18n/fr.ts 2015-10-15 16:55:00 +0000
+++ resources/i18n/fr.ts 2015-11-11 12:38:06 +0000
@@ -7628,10 +7628,10 @@
7628 </message>7628 </message>
7629</context>7629</context>
7630<context>7630<context>
7631 <name>PresentationPlugin.PowerpointDocument</name>7631 <name>PresentationPlugin.PowerPointDocument</name>
7632 <message>7632 <message>
7633 <location filename="openlp/plugins/presentations/lib/powerpointcontroller.py" line="517"/>7633 <location filename="openlp/plugins/presentations/lib/powerpointcontroller.py" line="517"/>
7634 <source>An error occurred in the Powerpoint integration and the presentation will be stopped. Restart the presentation if you wish to present it.</source>7634 <source>An error occurred in the PowerPoint integration and the presentation will be stopped. Restart the presentation if you wish to present it.</source>
7635 <translation type="unfinished"/>7635 <translation type="unfinished"/>
7636 </message>7636 </message>
7637</context>7637</context>
76387638
=== modified file 'resources/i18n/hu.ts'
--- resources/i18n/hu.ts 2015-10-15 16:55:00 +0000
+++ resources/i18n/hu.ts 2015-11-11 12:38:06 +0000
@@ -7711,11 +7711,11 @@
7711 </message>7711 </message>
7712</context>7712</context>
7713<context>7713<context>
7714 <name>PresentationPlugin.PowerpointDocument</name>7714 <name>PresentationPlugin.PowerPointDocument</name>
7715 <message>7715 <message>
7716 <location filename="openlp/plugins/presentations/lib/powerpointcontroller.py" line="517"/>7716 <location filename="openlp/plugins/presentations/lib/powerpointcontroller.py" line="517"/>
7717 <source>An error occurred in the Powerpoint integration and the presentation will be stopped. Restart the presentation if you wish to present it.</source>7717 <source>An error occurred in the PowerPoint integration and the presentation will be stopped. Restart the presentation if you wish to present it.</source>
7718 <translation>Hiba történt a Powerpoint integrációban, ezért a prezentáció leáll. Újraindítással lehet újra bemutatni a prezentációt.</translation>7718 <translation>Hiba történt a PowerPoint integrációban, ezért a prezentáció leáll. Újraindítással lehet újra bemutatni a prezentációt.</translation>
7719 </message>7719 </message>
7720</context>7720</context>
7721<context>7721<context>
77227722
=== modified file 'resources/i18n/id.ts'
--- resources/i18n/id.ts 2015-10-15 16:55:00 +0000
+++ resources/i18n/id.ts 2015-11-11 12:38:06 +0000
@@ -7711,10 +7711,10 @@
7711 </message>7711 </message>
7712</context>7712</context>
7713<context>7713<context>
7714 <name>PresentationPlugin.PowerpointDocument</name>7714 <name>PresentationPlugin.PowerPointDocument</name>
7715 <message>7715 <message>
7716 <location filename="openlp/plugins/presentations/lib/powerpointcontroller.py" line="517"/>7716 <location filename="openlp/plugins/presentations/lib/powerpointcontroller.py" line="517"/>
7717 <source>An error occurred in the Powerpoint integration and the presentation will be stopped. Restart the presentation if you wish to present it.</source>7717 <source>An error occurred in the PowerPoint integration and the presentation will be stopped. Restart the presentation if you wish to present it.</source>
7718 <translation>Terjadi kesalahan dalam integrasi PowerPoint dan presentasi akan dihentikan. Silakan mulai-ulang presentasi jika Anda ingin menampilkannya.</translation>7718 <translation>Terjadi kesalahan dalam integrasi PowerPoint dan presentasi akan dihentikan. Silakan mulai-ulang presentasi jika Anda ingin menampilkannya.</translation>
7719 </message>7719 </message>
7720</context>7720</context>
77217721
=== modified file 'resources/i18n/ja.ts'
--- resources/i18n/ja.ts 2015-10-15 16:55:00 +0000
+++ resources/i18n/ja.ts 2015-11-11 12:38:06 +0000
@@ -7705,10 +7705,10 @@
7705 </message>7705 </message>
7706</context>7706</context>
7707<context>7707<context>
7708 <name>PresentationPlugin.PowerpointDocument</name>7708 <name>PresentationPlugin.PowerPointDocument</name>
7709 <message>7709 <message>
7710 <location filename="openlp/plugins/presentations/lib/powerpointcontroller.py" line="517"/>7710 <location filename="openlp/plugins/presentations/lib/powerpointcontroller.py" line="517"/>
7711 <source>An error occurred in the Powerpoint integration and the presentation will be stopped. Restart the presentation if you wish to present it.</source>7711 <source>An error occurred in the PowerPoint integration and the presentation will be stopped. Restart the presentation if you wish to present it.</source>
7712 <translation>PowerPointとの通信にエラーが発生し、プレゼンテーションが終了しました。表示するには、プレゼンテーションをもう一度開始してください。</translation>7712 <translation>PowerPointとの通信にエラーが発生し、プレゼンテーションが終了しました。表示するには、プレゼンテーションをもう一度開始してください。</translation>
7713 </message>7713 </message>
7714</context>7714</context>
77157715
=== modified file 'resources/i18n/ko.ts'
--- resources/i18n/ko.ts 2015-10-15 16:55:00 +0000
+++ resources/i18n/ko.ts 2015-11-11 12:38:06 +0000
@@ -7578,10 +7578,10 @@
7578 </message>7578 </message>
7579</context>7579</context>
7580<context>7580<context>
7581 <name>PresentationPlugin.PowerpointDocument</name>7581 <name>PresentationPlugin.PowerPointDocument</name>
7582 <message>7582 <message>
7583 <location filename="openlp/plugins/presentations/lib/powerpointcontroller.py" line="517"/>7583 <location filename="openlp/plugins/presentations/lib/powerpointcontroller.py" line="517"/>
7584 <source>An error occurred in the Powerpoint integration and the presentation will be stopped. Restart the presentation if you wish to present it.</source>7584 <source>An error occurred in the PowerPoint integration and the presentation will be stopped. Restart the presentation if you wish to present it.</source>
7585 <translation type="unfinished"/>7585 <translation type="unfinished"/>
7586 </message>7586 </message>
7587</context>7587</context>
75887588
=== modified file 'resources/i18n/lt.ts'
--- resources/i18n/lt.ts 2015-10-15 16:55:00 +0000
+++ resources/i18n/lt.ts 2015-11-11 12:38:06 +0000
@@ -7710,11 +7710,11 @@
7710 </message>7710 </message>
7711</context>7711</context>
7712<context>7712<context>
7713 <name>PresentationPlugin.PowerpointDocument</name>7713 <name>PresentationPlugin.PowerPointDocument</name>
7714 <message>7714 <message>
7715 <location filename="openlp/plugins/presentations/lib/powerpointcontroller.py" line="517"/>7715 <location filename="openlp/plugins/presentations/lib/powerpointcontroller.py" line="517"/>
7716 <source>An error occurred in the Powerpoint integration and the presentation will be stopped. Restart the presentation if you wish to present it.</source>7716 <source>An error occurred in the PowerPoint integration and the presentation will be stopped. Restart the presentation if you wish to present it.</source>
7717 <translation>Powerpoint integravime įvyko klaida ir pateiktis bus sustabdyta. Paleiskite pateiktį iš naujo, jei norite ją pristatyti.</translation>7717 <translation>PowerPoint integravime įvyko klaida ir pateiktis bus sustabdyta. Paleiskite pateiktį iš naujo, jei norite ją pristatyti.</translation>
7718 </message>7718 </message>
7719</context>7719</context>
7720<context>7720<context>
77217721
=== modified file 'resources/i18n/nb.ts'
--- resources/i18n/nb.ts 2015-10-15 16:55:00 +0000
+++ resources/i18n/nb.ts 2015-11-11 12:38:06 +0000
@@ -7709,11 +7709,11 @@
7709 </message>7709 </message>
7710</context>7710</context>
7711<context>7711<context>
7712 <name>PresentationPlugin.PowerpointDocument</name>7712 <name>PresentationPlugin.PowerPointDocument</name>
7713 <message>7713 <message>
7714 <location filename="openlp/plugins/presentations/lib/powerpointcontroller.py" line="517"/>7714 <location filename="openlp/plugins/presentations/lib/powerpointcontroller.py" line="517"/>
7715 <source>An error occurred in the Powerpoint integration and the presentation will be stopped. Restart the presentation if you wish to present it.</source>7715 <source>An error occurred in the PowerPoint integration and the presentation will be stopped. Restart the presentation if you wish to present it.</source>
7716 <translation>Det oppstod en feil i Powerpointintegrasjonen og presentasjonen vil bli stoppet. Start presentasjonen på nytt hvis du ønsker å fortsette.</translation>7716 <translation>Det oppstod en feil i PowerPointintegrasjonen og presentasjonen vil bli stoppet. Start presentasjonen på nytt hvis du ønsker å fortsette.</translation>
7717 </message>7717 </message>
7718</context>7718</context>
7719<context>7719<context>
77207720
=== modified file 'resources/i18n/nl.ts'
--- resources/i18n/nl.ts 2015-10-15 17:34:42 +0000
+++ resources/i18n/nl.ts 2015-11-11 12:38:06 +0000
@@ -2419,7 +2419,7 @@
2419OpenLP is written and maintained by volunteers. If you would like to see more free Christian software being written, please consider volunteering by using the button below.</source>2419OpenLP is written and maintained by volunteers. If you would like to see more free Christian software being written, please consider volunteering by using the button below.</source>
2420 <translation>OpenLP &lt;version&gt;&lt;revision&gt; - Open Source Lyrics Projection2420 <translation>OpenLP &lt;version&gt;&lt;revision&gt; - Open Source Lyrics Projection
24212421
2422OpenLP is gratis presentatiesoftware voor kerken. Het kan gebruikt worden voor het projecteren van liedteksten, bijbelverzen, video&apos;s, afbeeldingen en zelfs bestaande presentaties uit Powerpoint.2422OpenLP is gratis presentatiesoftware voor kerken. Het kan gebruikt worden voor het projecteren van liedteksten, bijbelverzen, video&apos;s, afbeeldingen en zelfs bestaande presentaties uit PowerPoint.
24232423
2424Lees meer over OpenLP: http://openlp.org/2424Lees meer over OpenLP: http://openlp.org/
24252425
@@ -7712,11 +7712,11 @@
7712 </message>7712 </message>
7713</context>7713</context>
7714<context>7714<context>
7715 <name>PresentationPlugin.PowerpointDocument</name>7715 <name>PresentationPlugin.PowerPointDocument</name>
7716 <message>7716 <message>
7717 <location filename="openlp/plugins/presentations/lib/powerpointcontroller.py" line="517"/>7717 <location filename="openlp/plugins/presentations/lib/powerpointcontroller.py" line="517"/>
7718 <source>An error occurred in the Powerpoint integration and the presentation will be stopped. Restart the presentation if you wish to present it.</source>7718 <source>An error occurred in the PowerPoint integration and the presentation will be stopped. Restart the presentation if you wish to present it.</source>
7719 <translation>Er is een fout opgetreden in de Powerpoint-integratie waardoor de presentatie zal worden gestopt. U kunt de presentatie herstarten om verder te gaan met presenteren.</translation>7719 <translation>Er is een fout opgetreden in de PowerPoint-integratie waardoor de presentatie zal worden gestopt. U kunt de presentatie herstarten om verder te gaan met presenteren.</translation>
7720 </message>7720 </message>
7721</context>7721</context>
7722<context>7722<context>
77237723
=== modified file 'resources/i18n/pl.ts'
--- resources/i18n/pl.ts 2015-10-15 16:55:00 +0000
+++ resources/i18n/pl.ts 2015-11-11 12:38:06 +0000
@@ -7709,11 +7709,11 @@
7709 </message>7709 </message>
7710</context>7710</context>
7711<context>7711<context>
7712 <name>PresentationPlugin.PowerpointDocument</name>7712 <name>PresentationPlugin.PowerPointDocument</name>
7713 <message>7713 <message>
7714 <location filename="openlp/plugins/presentations/lib/powerpointcontroller.py" line="517"/>7714 <location filename="openlp/plugins/presentations/lib/powerpointcontroller.py" line="517"/>
7715 <source>An error occurred in the Powerpoint integration and the presentation will be stopped. Restart the presentation if you wish to present it.</source>7715 <source>An error occurred in the PowerPoint integration and the presentation will be stopped. Restart the presentation if you wish to present it.</source>
7716 <translation>Wystąpił błąd we współpracy z Powerpointem i prezentacja zostanie zatrzymana. Uruchom ją ponownie, jeśli chcesz ją zaprezentować.</translation>7716 <translation>Wystąpił błąd we współpracy z PowerPointem i prezentacja zostanie zatrzymana. Uruchom ją ponownie, jeśli chcesz ją zaprezentować.</translation>
7717 </message>7717 </message>
7718</context>7718</context>
7719<context>7719<context>
77207720
=== modified file 'resources/i18n/pt_BR.ts'
--- resources/i18n/pt_BR.ts 2015-10-15 16:55:00 +0000
+++ resources/i18n/pt_BR.ts 2015-11-11 12:38:06 +0000
@@ -7612,10 +7612,10 @@
7612 </message>7612 </message>
7613</context>7613</context>
7614<context>7614<context>
7615 <name>PresentationPlugin.PowerpointDocument</name>7615 <name>PresentationPlugin.PowerPointDocument</name>
7616 <message>7616 <message>
7617 <location filename="openlp/plugins/presentations/lib/powerpointcontroller.py" line="517"/>7617 <location filename="openlp/plugins/presentations/lib/powerpointcontroller.py" line="517"/>
7618 <source>An error occurred in the Powerpoint integration and the presentation will be stopped. Restart the presentation if you wish to present it.</source>7618 <source>An error occurred in the PowerPoint integration and the presentation will be stopped. Restart the presentation if you wish to present it.</source>
7619 <translation type="unfinished"/>7619 <translation type="unfinished"/>
7620 </message>7620 </message>
7621</context>7621</context>
76227622
=== modified file 'resources/i18n/ru.ts'
--- resources/i18n/ru.ts 2015-10-15 16:55:00 +0000
+++ resources/i18n/ru.ts 2015-11-11 12:38:06 +0000
@@ -7661,10 +7661,10 @@
7661 </message>7661 </message>
7662</context>7662</context>
7663<context>7663<context>
7664 <name>PresentationPlugin.PowerpointDocument</name>7664 <name>PresentationPlugin.PowerPointDocument</name>
7665 <message>7665 <message>
7666 <location filename="openlp/plugins/presentations/lib/powerpointcontroller.py" line="517"/>7666 <location filename="openlp/plugins/presentations/lib/powerpointcontroller.py" line="517"/>
7667 <source>An error occurred in the Powerpoint integration and the presentation will be stopped. Restart the presentation if you wish to present it.</source>7667 <source>An error occurred in the PowerPoint integration and the presentation will be stopped. Restart the presentation if you wish to present it.</source>
7668 <translation type="unfinished"/>7668 <translation type="unfinished"/>
7669 </message>7669 </message>
7670</context>7670</context>
76717671
=== modified file 'resources/i18n/sk.ts'
--- resources/i18n/sk.ts 2015-10-15 16:55:00 +0000
+++ resources/i18n/sk.ts 2015-11-11 12:38:06 +0000
@@ -7691,11 +7691,11 @@
7691 </message>7691 </message>
7692</context>7692</context>
7693<context>7693<context>
7694 <name>PresentationPlugin.PowerpointDocument</name>7694 <name>PresentationPlugin.PowerPointDocument</name>
7695 <message>7695 <message>
7696 <location filename="openlp/plugins/presentations/lib/powerpointcontroller.py" line="517"/>7696 <location filename="openlp/plugins/presentations/lib/powerpointcontroller.py" line="517"/>
7697 <source>An error occurred in the Powerpoint integration and the presentation will be stopped. Restart the presentation if you wish to present it.</source>7697 <source>An error occurred in the PowerPoint integration and the presentation will be stopped. Restart the presentation if you wish to present it.</source>
7698 <translation>Vznikla chyba pri integrácií Powerpointu a prezentácia bude ukončená. Ak chete zobraziť prezentáciu, spustite ju znovu.</translation>7698 <translation>Vznikla chyba pri integrácií PowerPointu a prezentácia bude ukončená. Ak chete zobraziť prezentáciu, spustite ju znovu.</translation>
7699 </message>7699 </message>
7700</context>7700</context>
7701<context>7701<context>
77027702
=== modified file 'resources/i18n/sv.ts'
--- resources/i18n/sv.ts 2015-10-15 16:55:00 +0000
+++ resources/i18n/sv.ts 2015-11-11 12:38:06 +0000
@@ -7710,11 +7710,11 @@
7710 </message>7710 </message>
7711</context>7711</context>
7712<context>7712<context>
7713 <name>PresentationPlugin.PowerpointDocument</name>7713 <name>PresentationPlugin.PowerPointDocument</name>
7714 <message>7714 <message>
7715 <location filename="openlp/plugins/presentations/lib/powerpointcontroller.py" line="517"/>7715 <location filename="openlp/plugins/presentations/lib/powerpointcontroller.py" line="517"/>
7716 <source>An error occurred in the Powerpoint integration and the presentation will be stopped. Restart the presentation if you wish to present it.</source>7716 <source>An error occurred in the PowerPoint integration and the presentation will be stopped. Restart the presentation if you wish to present it.</source>
7717 <translation>Ett fel inträffade i Powerpoint-integrationen och presentationen kommer att avbrytas. Starta om presentationen om du vill visa den.</translation>7717 <translation>Ett fel inträffade i PowerPoint-integrationen och presentationen kommer att avbrytas. Starta om presentationen om du vill visa den.</translation>
7718 </message>7718 </message>
7719</context>7719</context>
7720<context>7720<context>
77217721
=== modified file 'resources/i18n/ta_LK.ts'
--- resources/i18n/ta_LK.ts 2015-10-15 16:55:00 +0000
+++ resources/i18n/ta_LK.ts 2015-11-11 12:38:06 +0000
@@ -7606,10 +7606,10 @@
7606 </message>7606 </message>
7607</context>7607</context>
7608<context>7608<context>
7609 <name>PresentationPlugin.PowerpointDocument</name>7609 <name>PresentationPlugin.PowerPointDocument</name>
7610 <message>7610 <message>
7611 <location filename="openlp/plugins/presentations/lib/powerpointcontroller.py" line="517"/>7611 <location filename="openlp/plugins/presentations/lib/powerpointcontroller.py" line="517"/>
7612 <source>An error occurred in the Powerpoint integration and the presentation will be stopped. Restart the presentation if you wish to present it.</source>7612 <source>An error occurred in the PowerPoint integration and the presentation will be stopped. Restart the presentation if you wish to present it.</source>
7613 <translation type="unfinished"/>7613 <translation type="unfinished"/>
7614 </message>7614 </message>
7615</context>7615</context>
76167616
=== modified file 'resources/i18n/th_TH.ts'
--- resources/i18n/th_TH.ts 2015-10-15 16:55:00 +0000
+++ resources/i18n/th_TH.ts 2015-11-11 12:38:06 +0000
@@ -7606,10 +7606,10 @@
7606 </message>7606 </message>
7607</context>7607</context>
7608<context>7608<context>
7609 <name>PresentationPlugin.PowerpointDocument</name>7609 <name>PresentationPlugin.PowerPointDocument</name>
7610 <message>7610 <message>
7611 <location filename="openlp/plugins/presentations/lib/powerpointcontroller.py" line="517"/>7611 <location filename="openlp/plugins/presentations/lib/powerpointcontroller.py" line="517"/>
7612 <source>An error occurred in the Powerpoint integration and the presentation will be stopped. Restart the presentation if you wish to present it.</source>7612 <source>An error occurred in the PowerPoint integration and the presentation will be stopped. Restart the presentation if you wish to present it.</source>
7613 <translation type="unfinished"/>7613 <translation type="unfinished"/>
7614 </message>7614 </message>
7615</context>7615</context>
76167616
=== modified file 'resources/i18n/zh_CN.ts'
--- resources/i18n/zh_CN.ts 2015-10-15 16:55:00 +0000
+++ resources/i18n/zh_CN.ts 2015-11-11 12:38:06 +0000
@@ -7603,10 +7603,10 @@
7603 </message>7603 </message>
7604</context>7604</context>
7605<context>7605<context>
7606 <name>PresentationPlugin.PowerpointDocument</name>7606 <name>PresentationPlugin.PowerPointDocument</name>
7607 <message>7607 <message>
7608 <location filename="openlp/plugins/presentations/lib/powerpointcontroller.py" line="517"/>7608 <location filename="openlp/plugins/presentations/lib/powerpointcontroller.py" line="517"/>
7609 <source>An error occurred in the Powerpoint integration and the presentation will be stopped. Restart the presentation if you wish to present it.</source>7609 <source>An error occurred in the PowerPoint integration and the presentation will be stopped. Restart the presentation if you wish to present it.</source>
7610 <translation type="unfinished"/>7610 <translation type="unfinished"/>
7611 </message>7611 </message>
7612</context>7612</context>
76137613
=== modified file 'resources/i18n/zh_TW.ts'
--- resources/i18n/zh_TW.ts 2015-10-15 16:55:00 +0000
+++ resources/i18n/zh_TW.ts 2015-11-11 12:38:06 +0000
@@ -7706,11 +7706,11 @@
7706 </message>7706 </message>
7707</context>7707</context>
7708<context>7708<context>
7709 <name>PresentationPlugin.PowerpointDocument</name>7709 <name>PresentationPlugin.PowerPointDocument</name>
7710 <message>7710 <message>
7711 <location filename="openlp/plugins/presentations/lib/powerpointcontroller.py" line="517"/>7711 <location filename="openlp/plugins/presentations/lib/powerpointcontroller.py" line="517"/>
7712 <source>An error occurred in the Powerpoint integration and the presentation will be stopped. Restart the presentation if you wish to present it.</source>7712 <source>An error occurred in the PowerPoint integration and the presentation will be stopped. Restart the presentation if you wish to present it.</source>
7713 <translation>整合Powerpoint時發生了錯誤,簡報即將結束。若您希望顯示,請重新啟動簡報。</translation>7713 <translation>整合PowerPoint時發生了錯誤,簡報即將結束。若您希望顯示,請重新啟動簡報。</translation>
7714 </message>7714 </message>
7715</context>7715</context>
7716<context>7716<context>
77177717
=== modified file 'tests/functional/openlp_plugins/presentations/test_mediaitem.py'
--- tests/functional/openlp_plugins/presentations/test_mediaitem.py 2015-03-18 22:04:30 +0000
+++ tests/functional/openlp_plugins/presentations/test_mediaitem.py 2015-11-11 12:38:06 +0000
@@ -68,8 +68,8 @@
68 # Mock the controllers.68 # Mock the controllers.
69 self.media_item.controllers = {69 self.media_item.controllers = {
70 'Impress': impress_controller,70 'Impress': impress_controller,
71 'Powerpoint': presentation_controller,71 'PowerPoint': presentation_controller,
72 'Powerpoint Viewer': presentation_viewer_controller,72 'PowerPoint Viewer': presentation_viewer_controller,
73 'Pdf': pdf_controller73 'Pdf': pdf_controller
74 }74 }
7575
7676
=== modified file 'tests/functional/openlp_plugins/presentations/test_powerpointcontroller.py'
--- tests/functional/openlp_plugins/presentations/test_powerpointcontroller.py 2015-05-05 13:20:24 +0000
+++ tests/functional/openlp_plugins/presentations/test_powerpointcontroller.py 2015-11-11 12:38:06 +0000
@@ -31,7 +31,7 @@
31from tests.helpers.testmixin import TestMixin31from tests.helpers.testmixin import TestMixin
32from tests.utils.constants import TEST_RESOURCES_PATH32from tests.utils.constants import TEST_RESOURCES_PATH
3333
34from openlp.plugins.presentations.lib.powerpointcontroller import PowerpointController, PowerpointDocument,\34from openlp.plugins.presentations.lib.powerpointcontroller import PowerPointController, PowerPointDocument,\
35 _get_text_from_shapes35 _get_text_from_shapes
36from openlp.core.common import is_win, Settings36from openlp.core.common import is_win, Settings
3737
@@ -43,9 +43,9 @@
43}43}
4444
4545
46class TestPowerpointController(TestCase, TestMixin):46class TestPowerPointController(TestCase, TestMixin):
47 """47 """
48 Test the PowerpointController Class48 Test the PowerPointController Class
49 """49 """
5050
51 def setUp(self):51 def setUp(self):
@@ -67,22 +67,22 @@
6767
68 def constructor_test(self):68 def constructor_test(self):
69 """69 """
70 Test the Constructor from the PowerpointController70 Test the Constructor from the PowerPointController
71 """71 """
72 # GIVEN: No presentation controller72 # GIVEN: No presentation controller
73 controller = None73 controller = None
7474
75 # WHEN: The presentation controller object is created75 # WHEN: The presentation controller object is created
76 controller = PowerpointController(plugin=self.mock_plugin)76 controller = PowerPointController(plugin=self.mock_plugin)
7777
78 # THEN: The name of the presentation controller should be correct78 # THEN: The name of the presentation controller should be correct
79 self.assertEqual('Powerpoint', controller.name,79 self.assertEqual('PowerPoint', controller.name,
80 'The name of the presentation controller should be correct')80 'The name of the presentation controller should be correct')
8181
8282
83class TestPowerpointDocument(TestCase, TestMixin):83class TestPowerPointDocument(TestCase, TestMixin):
84 """84 """
85 Test the PowerpointDocument Class85 Test the PowerPointDocument Class
86 """86 """
8787
88 def setUp(self):88 def setUp(self):
@@ -95,7 +95,7 @@
95 self.temp_folder = mkdtemp()95 self.temp_folder = mkdtemp()
96 self.mock_plugin.settings_section = self.temp_folder96 self.mock_plugin.settings_section = self.temp_folder
97 self.powerpoint_document_stop_presentation_patcher = patch(97 self.powerpoint_document_stop_presentation_patcher = patch(
98 'openlp.plugins.presentations.lib.powerpointcontroller.PowerpointDocument.stop_presentation')98 'openlp.plugins.presentations.lib.powerpointcontroller.PowerPointDocument.stop_presentation')
99 self.presentation_document_get_temp_folder_patcher = patch(99 self.presentation_document_get_temp_folder_patcher = patch(
100 'openlp.plugins.presentations.lib.powerpointcontroller.PresentationDocument.get_temp_folder')100 'openlp.plugins.presentations.lib.powerpointcontroller.PresentationDocument.get_temp_folder')
101 self.presentation_document_setup_patcher = patch(101 self.presentation_document_setup_patcher = patch(
@@ -107,7 +107,7 @@
107 self.mock_presentation = MagicMock()107 self.mock_presentation = MagicMock()
108 self.mock_presentation_document_get_temp_folder.return_value = 'temp folder'108 self.mock_presentation_document_get_temp_folder.return_value = 'temp folder'
109 self.file_name = os.path.join(TEST_RESOURCES_PATH, 'presentations', 'test.pptx')109 self.file_name = os.path.join(TEST_RESOURCES_PATH, 'presentations', 'test.pptx')
110 self.real_controller = PowerpointController(self.mock_plugin)110 self.real_controller = PowerPointController(self.mock_plugin)
111 Settings().extend_default_settings(__default_settings__)111 Settings().extend_default_settings(__default_settings__)
112112
113 def tearDown(self):113 def tearDown(self):
@@ -122,13 +122,13 @@
122122
123 def show_error_msg_test(self):123 def show_error_msg_test(self):
124 """124 """
125 Test the PowerpointDocument.show_error_msg() method gets called on com exception125 Test the PowerPointDocument.show_error_msg() method gets called on com exception
126 """126 """
127 if is_win():127 if is_win():
128 # GIVEN: A PowerpointDocument with mocked controller and presentation128 # GIVEN: A PowerPointDocument with mocked controller and presentation
129 with patch('openlp.plugins.presentations.lib.powerpointcontroller.critical_error_message_box') as \129 with patch('openlp.plugins.presentations.lib.powerpointcontroller.critical_error_message_box') as \
130 mocked_critical_error_message_box:130 mocked_critical_error_message_box:
131 instance = PowerpointDocument(self.mock_controller, self.mock_presentation)131 instance = PowerPointDocument(self.mock_controller, self.mock_presentation)
132 instance.presentation = MagicMock()132 instance.presentation = MagicMock()
133 instance.presentation.SlideShowWindow.View.GotoSlide = MagicMock(side_effect=pywintypes.com_error('1'))133 instance.presentation.SlideShowWindow.View.GotoSlide = MagicMock(side_effect=pywintypes.com_error('1'))
134 instance.index_map[42] = 42134 instance.index_map[42] = 42
@@ -137,7 +137,7 @@
137 instance.goto_slide(42)137 instance.goto_slide(42)
138138
139 # THEN: mocked_critical_error_message_box should have been called139 # THEN: mocked_critical_error_message_box should have been called
140 mocked_critical_error_message_box.assert_called_with('Error', 'An error occurred in the Powerpoint '140 mocked_critical_error_message_box.assert_called_with('Error', 'An error occurred in the PowerPoint '
141 'integration and the presentation will be stopped.'141 'integration and the presentation will be stopped.'
142 ' Restart the presentation if you wish to '142 ' Restart the presentation if you wish to '
143 'present it.')143 'present it.')
@@ -148,8 +148,8 @@
148 Test loading a document in PowerPoint148 Test loading a document in PowerPoint
149 """149 """
150 if is_win() and self.real_controller.check_available():150 if is_win() and self.real_controller.check_available():
151 # GIVEN: A PowerpointDocument and a presentation151 # GIVEN: A PowerPointDocument and a presentation
152 doc = PowerpointDocument(self.real_controller, self.file_name)152 doc = PowerPointDocument(self.real_controller, self.file_name)
153153
154 # WHEN: loading the filename154 # WHEN: loading the filename
155 doc.load_presentation()155 doc.load_presentation()
@@ -158,19 +158,19 @@
158 # THEN: result should be true158 # THEN: result should be true
159 self.assertEqual(result, True, 'The result should be True')159 self.assertEqual(result, True, 'The result should be True')
160 else:160 else:
161 self.skipTest('Powerpoint not available, skipping test.')161 self.skipTest('PowerPoint not available, skipping test.')
162162
163 def create_titles_and_notes_test(self):163 def create_titles_and_notes_test(self):
164 """164 """
165 Test creating the titles from PowerPoint165 Test creating the titles from PowerPoint
166 """166 """
167 # GIVEN: mocked save_titles_and_notes, _get_text_from_shapes and two mocked slides167 # GIVEN: mocked save_titles_and_notes, _get_text_from_shapes and two mocked slides
168 self.doc = PowerpointDocument(self.mock_controller, self.file_name)168 self.doc = PowerPointDocument(self.mock_controller, self.file_name)
169 self.doc.get_slide_count = MagicMock()169 self.doc.get_slide_count = MagicMock()
170 self.doc.get_slide_count.return_value = 2170 self.doc.get_slide_count.return_value = 2
171 self.doc.index_map = {1: 1, 2: 2}171 self.doc.index_map = {1: 1, 2: 2}
172 self.doc.save_titles_and_notes = MagicMock()172 self.doc.save_titles_and_notes = MagicMock()
173 self.doc._PowerpointDocument__get_text_from_shapes = MagicMock()173 self.doc._PowerPointDocument__get_text_from_shapes = MagicMock()
174 slide = MagicMock()174 slide = MagicMock()
175 slide.Shapes.Title.TextFrame.TextRange.Text = 'SlideText'175 slide.Shapes.Title.TextFrame.TextRange.Text = 'SlideText'
176 pres = MagicMock()176 pres = MagicMock()
@@ -188,9 +188,9 @@
188 Test creating the titles from PowerPoint when it returns no slides188 Test creating the titles from PowerPoint when it returns no slides
189 """189 """
190 # GIVEN: mocked save_titles_and_notes, _get_text_from_shapes and two mocked slides190 # GIVEN: mocked save_titles_and_notes, _get_text_from_shapes and two mocked slides
191 doc = PowerpointDocument(self.mock_controller, self.file_name)191 doc = PowerPointDocument(self.mock_controller, self.file_name)
192 doc.save_titles_and_notes = MagicMock()192 doc.save_titles_and_notes = MagicMock()
193 doc._PowerpointDocument__get_text_from_shapes = MagicMock()193 doc._PowerPointDocument__get_text_from_shapes = MagicMock()
194 pres = MagicMock()194 pres = MagicMock()
195 pres.Slides = []195 pres.Slides = []
196 doc.presentation = pres196 doc.presentation = pres
@@ -236,7 +236,7 @@
236 Test that goto_slide goes to next effect if the slide is already displayed236 Test that goto_slide goes to next effect if the slide is already displayed
237 """237 """
238 # GIVEN: A Document with mocked controller, presentation, and mocked functions get_slide_number and next_step238 # GIVEN: A Document with mocked controller, presentation, and mocked functions get_slide_number and next_step
239 doc = PowerpointDocument(self.mock_controller, self.mock_presentation)239 doc = PowerPointDocument(self.mock_controller, self.mock_presentation)
240 doc.presentation = MagicMock()240 doc.presentation = MagicMock()
241 doc.presentation.SlideShowWindow.View.GetClickIndex.return_value = 1241 doc.presentation.SlideShowWindow.View.GetClickIndex.return_value = 1
242 doc.presentation.SlideShowWindow.View.GetClickCount.return_value = 2242 doc.presentation.SlideShowWindow.View.GetClickCount.return_value = 2
@@ -256,7 +256,7 @@
256 Test that blank_screen works as expected256 Test that blank_screen works as expected
257 """257 """
258 # GIVEN: A Document with mocked controller, presentation, and mocked function get_slide_number258 # GIVEN: A Document with mocked controller, presentation, and mocked function get_slide_number
259 doc = PowerpointDocument(self.mock_controller, self.mock_presentation)259 doc = PowerPointDocument(self.mock_controller, self.mock_presentation)
260 doc.presentation = MagicMock()260 doc.presentation = MagicMock()
261 doc.presentation.SlideShowWindow.View.GetClickIndex.return_value = 3261 doc.presentation.SlideShowWindow.View.GetClickIndex.return_value = 3
262 doc.presentation.Application.Version = 14.0262 doc.presentation.Application.Version = 14.0
@@ -280,7 +280,7 @@
280 mocked_screen_list_ret = MagicMock()280 mocked_screen_list_ret = MagicMock()
281 mocked_screen_list_ret.screen_list = [1]281 mocked_screen_list_ret.screen_list = [1]
282 mocked_screen_list.return_value = mocked_screen_list_ret282 mocked_screen_list.return_value = mocked_screen_list_ret
283 doc = PowerpointDocument(self.mock_controller, self.mock_presentation)283 doc = PowerPointDocument(self.mock_controller, self.mock_presentation)
284 doc.presentation = MagicMock()284 doc.presentation = MagicMock()
285 doc.presentation.SlideShowWindow.View.GetClickIndex.return_value = 3285 doc.presentation.SlideShowWindow.View.GetClickIndex.return_value = 3
286 doc.presentation.Application.Version = 14.0286 doc.presentation.Application.Version = 14.0
287287
=== modified file 'tests/functional/openlp_plugins/presentations/test_pptviewcontroller.py'
--- tests/functional/openlp_plugins/presentations/test_pptviewcontroller.py 2015-01-18 13:39:21 +0000
+++ tests/functional/openlp_plugins/presentations/test_pptviewcontroller.py 2015-11-11 12:38:06 +0000
@@ -76,7 +76,7 @@
76 controller = PptviewController(plugin=self.mock_plugin)76 controller = PptviewController(plugin=self.mock_plugin)
7777
78 # THEN: The name of the presentation controller should be correct78 # THEN: The name of the presentation controller should be correct
79 self.assertEqual('Powerpoint Viewer', controller.name,79 self.assertEqual('PowerPoint Viewer', controller.name,
80 'The name of the presentation controller should be correct')80 'The name of the presentation controller should be correct')
8181
82 def check_available_test(self):82 def check_available_test(self):
@@ -204,7 +204,7 @@
204204
205 def create_titles_and_notes_test(self):205 def create_titles_and_notes_test(self):
206 """206 """
207 Test PowerpointController.create_titles_and_notes207 Test PowerPointController.create_titles_and_notes
208 """208 """
209 # GIVEN: mocked PresentationController.save_titles_and_notes and a pptx file209 # GIVEN: mocked PresentationController.save_titles_and_notes and a pptx file
210 doc = PptviewDocument(self.mock_controller, self.mock_presentation)210 doc = PptviewDocument(self.mock_controller, self.mock_presentation)
@@ -221,7 +221,7 @@
221221
222 def create_titles_and_notes_nonexistent_file_test(self):222 def create_titles_and_notes_nonexistent_file_test(self):
223 """223 """
224 Test PowerpointController.create_titles_and_notes with nonexistent file224 Test PowerPointController.create_titles_and_notes with nonexistent file
225 """225 """
226 # GIVEN: mocked PresentationController.save_titles_and_notes and an nonexistent file226 # GIVEN: mocked PresentationController.save_titles_and_notes and an nonexistent file
227 with patch('builtins.open') as mocked_open, \227 with patch('builtins.open') as mocked_open, \
@@ -244,7 +244,7 @@
244244
245 def create_titles_and_notes_invalid_file_test(self):245 def create_titles_and_notes_invalid_file_test(self):
246 """246 """
247 Test PowerpointController.create_titles_and_notes with invalid file247 Test PowerPointController.create_titles_and_notes with invalid file
248 """248 """
249 # GIVEN: mocked PresentationController.save_titles_and_notes and an invalid file249 # GIVEN: mocked PresentationController.save_titles_and_notes and an invalid file
250 with patch('builtins.open') as mocked_open, \250 with patch('builtins.open') as mocked_open, \