Merge lp:~suutari-olli/openlp/change-blank-to-desktop-hotkey-to-esc into lp:openlp
Status: | Superseded | ||||||||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Proposed branch: | lp:~suutari-olli/openlp/change-blank-to-desktop-hotkey-to-esc | ||||||||||||||||||||
Merge into: | lp:openlp | ||||||||||||||||||||
Diff against target: |
232 lines (+59/-51) 6 files modified
openlp/core/common/settings.py (+8/-5) openlp/core/ui/mainwindow.py (+16/-32) openlp/core/ui/shortcutlistform.py (+3/-3) openlp/core/ui/slidecontroller.py (+11/-10) resources/images/openlp-2.qrc (+0/-1) tests/functional/openlp_plugins/bibles/test_mediaitem.py (+21/-0) |
||||||||||||||||||||
To merge this branch: | bzr merge lp:~suutari-olli/openlp/change-blank-to-desktop-hotkey-to-esc | ||||||||||||||||||||
Related bugs: |
|
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Tim Bentley | Needs Fixing | ||
Review via email: mp+302896@code.launchpad.net |
This proposal supersedes a proposal from 2016-08-14.
This proposal has been superseded by a proposal from 2016-08-20.
Description of the change
- Changed the default shortcuts for Blank to desktop to Esc + D
- Removed default shortcut for "Escape item"
- Combined Offline & Online help buttons into "User Manual" button,
which launches the appropriate help based on OS. (Offline for Win/Mac)
- Fixed bugs:
https:/
https:/
lp:~suutari-olli/openlp/change-blank-to-desktop-hotkey-to-esc (revision 2699)
[SUCCESS] https:/
[SUCCESS] https:/
[SUCCESS] https:/
[SUCCESS] https:/
[SUCCESS] https:/
[SUCCESS] https:/
[SUCCESS] https:/
[SUCCESS] https:/
See the comment for the right place.
"This used to be in self.main_ window. warning_ message, where it was causing traceback.
Does it still work?
I'm not exactly sure of what it's supposed to do to be honest.
Is there a reason why this could not be an a separate line?"