Merge lp:~suligap/canonical-identity-provider/charm-ansible-become-instead-of-sudo into lp:~ubuntuone-pqm-team/canonical-identity-provider/charm

[Przemysław Suliga]

Move to become and become_user Ansible directives

Trying to fix the failing build for https://code.launchpad.net/~suligap/canonical-identity-provider/charm-talisker-soft-request-timeout/+merge/384493

[Przemysław Suliga (suligap)]

I don't really have experience with Ansible.

But looking at the failing job:

> ERROR! conflicting action statements: sudo_user, sudo

And the fact that is uses Ansible 2.9.9 to run the tests, I assume we are on this recent version of Ansible (not just for the tests). I've looked at https://docs.ansible.com/ansible/latest/user_guide/become.html to find that sudo* directives are deprecated and become and become_user are now in place.

[Daniel Manrique (roadmr)]

+1, let's try with the pinning in place.

review: Approve

[Otto Co-Pilot (otto-copilot)]

Project setup failed
https://jenkins.ols.canonical.com/online-services/job/canonical-identity-provider_charm/7/

[lp:~suligap/canonical-identity-provider/charm-ansible-become-instead-of-sudo]

93. By Przemysław Suliga on 2020-05-25

Pin setuptools to the last Python 2 compatible version

=== modified file 'charm.mk'
--- charm.mk	2019-08-15 21:49:05 +0000
+++ charm.mk	2020-05-25 15:21:39 +0000
@@ -130,7 +130,8 @@
 	# consistently after April 2018 due to
 	# https://packaging.python.org/guides/migrating-to-pypi-org/.
 	@$(PIP) install --upgrade pip
-	@$(PIP) install cryptography==2.0 ansible flake8
+	# Pin setuptools to the last Python 2 compatible version.
+	@$(PIP) install cryptography==2.0 ansible==2.0.0.2 flake8 "setuptools<45"
 	@[ -f requirements.txt ] && $(PIP) install -r requirements.txt || true
 
 $(CHARM_HELPERS_SYNC):