Merge ~suligap/canonical-identity-provider:talisker-statsd into canonical-identity-provider:master
Status: | Merged |
---|---|
Approved by: | Przemysław Suliga |
Approved revision: | 896f48aea116c5ad392bb8200424f33634e809f3 |
Merge reported by: | Otto Co-Pilot |
Merged at revision: | not available |
Proposed branch: | ~suligap/canonical-identity-provider:talisker-statsd |
Merge into: | canonical-identity-provider:master |
Prerequisite: | ~suligap/canonical-identity-provider:new-style-middleware |
Diff against target: |
25 lines (+2/-1) 2 files modified
django_project/settings_base.py (+1/-0) requirements.txt (+1/-1) |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Maximiliano Bertacchini | Approve | ||
Review via email: mp+384617@code.launchpad.net |
Commit message
Prepare for talisker's statsd integration
Description of the change
- Bump statsd package version to 3.3.0 (required by talisker for
configuring the statsd client)
- Add talisker.
After this, talisker can be configured using a STATSD_DSN env var to
send out various metrics to statsd. Currently those will be timers and
counters for views; example counter:
$prefix.
The middleware is needed for view name introspection, also for the
purposes of creating these metrics:
https:/
This also results in an X-View-Name response header being added.
Example:
X-View-Name: account-index
Enabling the metrics sending part requires adding a proper STATSD_DSN
env var to talisker's execution env. Later more metrics can be added by
switching to use talisker provided `requests` session for example.
Maybe later, we can look into replacing the django_statsd based
PistonRequestTi
They have a bit different naming structure (but it might be a win just
letting talisker decide here).
This depends on the new style middleware branch: https:/
+1