Merge ~sudeephb/charm-kubernetes-service-checks:release/2210 into charm-kubernetes-service-checks:master

Proposed by Sudeep Bhandari
Status: Merged
Approved by: Eric Chen
Approved revision: e92694e8749491c29542d4f96190eec106c06d7b
Merged at revision: dd278b8b7c7145776e85abef2bca7a39f46d8523
Proposed branch: ~sudeephb/charm-kubernetes-service-checks:release/2210
Merge into: charm-kubernetes-service-checks:master
Diff against target: 207 lines (+82/-41)
6 files modified
charmcraft.yaml (+5/-1)
metadata.yaml (+1/-0)
tests/functional/tests/bundles/base.yaml (+7/-38)
tests/functional/tests/bundles/jammy.yaml (+65/-0)
tests/functional/tests/bundles/overlays/jammy.yaml.j2 (+1/-0)
tests/functional/tests/tests.yaml (+3/-2)
Reviewer Review Type Date Requested Status
Eric Chen Approve
BootStack Reviewers Pending
Review via email: mp+429508@code.launchpad.net

Commit message

Added jammy support

Description of the change

To post a comment you must log in.
Revision history for this message
🤖 Canonical IS Merge Bot (canonical-is-mergebot) wrote :

This merge proposal is being monitored by mergebot. Change the status to Approved to merge.

Revision history for this message
Eric Chen (eric-chen) wrote :

some inline comment

review: Needs Information
Revision history for this message
Sudeep Bhandari (sudeephb) :
Revision history for this message
Sudeep Bhandari (sudeephb) :
Revision history for this message
Eric Chen (eric-chen) :
review: Approve
Revision history for this message
🤖 Canonical IS Merge Bot (canonical-is-mergebot) wrote :

Change successfully merged at revision dd278b8b7c7145776e85abef2bca7a39f46d8523

Revision history for this message
Robert Gildein (rgildein) :

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/charmcraft.yaml b/charmcraft.yaml
2index f0b71dd..900390b 100644
3--- a/charmcraft.yaml
4+++ b/charmcraft.yaml
5@@ -7,10 +7,14 @@ parts:
6 bases:
7 - build-on:
8 - name: ubuntu
9- channel: "20.04"
10+ channel: "22.04"
11 architectures: ["amd64"]
12 run-on:
13 - name: ubuntu
14+ channel: "22.04"
15+ architectures:
16+ - amd64
17+ - name: ubuntu
18 channel: "20.04"
19 architectures:
20 - amd64
21diff --git a/metadata.yaml b/metadata.yaml
22index ec0b730..714a4c8 100644
23--- a/metadata.yaml
24+++ b/metadata.yaml
25@@ -10,6 +10,7 @@ tags:
26 - ops
27 - monitoring
28 series:
29+ - jammy
30 - focal
31 - bionic
32 requires:
33diff --git a/tests/functional/tests/bundles/base.yaml b/tests/functional/tests/bundles/base.yaml
34index 4061cc7..785ae42 100644
35--- a/tests/functional/tests/bundles/base.yaml
36+++ b/tests/functional/tests/bundles/base.yaml
37@@ -2,62 +2,31 @@ applications:
38 kubernetes-service-checks:
39 num_units: 1
40 containerd:
41- charm: cs:~containers/containerd
42+ charm: ch:containers-containerd
43 options:
44 gpu_driver: none
45 resources: {}
46 easyrsa:
47- charm: cs:~containers/easyrsa
48+ charm: ch:containers-easyrsa
49 num_units: 1
50- resources:
51- easyrsa: 5
52 etcd:
53- charm: cs:~containers/etcd
54+ charm: ch:etcd
55 num_units: 1
56- options:
57- channel: 3.3/stable
58- resources:
59- core: 0
60- etcd: 3
61- snapshot: 0
62 flannel:
63- charm: cs:~containers/flannel
64- resources:
65- flannel-amd64: 625
66- flannel-arm64: 622
67- flannel-s390x: 609
68+ charm: ch:containers-flannel
69 kubernetes-master:
70- charm: cs:~containers/kubernetes-master
71+ charm: ch:kubernetes-control-plane
72 num_units: 1
73 constraints: cores=4 mem=4G root-disk=16G
74- options:
75- channel: 1.18/stable
76- resources:
77- cdk-addons: 0
78- core: 0
79- kube-apiserver: 0
80- kube-controller-manager: 0
81- kube-proxy: 0
82- kube-scheduler: 0
83- kubectl: 0
84 kubernetes-worker:
85- charm: cs:~containers/kubernetes-worker
86+ charm: ch:containers-kubernetes-worker
87 expose: true
88 num_units: 3
89 constraints: cores=4 mem=4G root-disk=16G
90 options:
91- channel: 1.18/stable
92 kubelet-extra-config: '{protectKernelDefaults: false}'
93- resources:
94- cni-amd64: 645
95- cni-arm64: 636
96- cni-s390x: 648
97- core: 0
98- kube-proxy: 0
99- kubectl: 0
100- kubelet: 0
101 nrpe:
102- charm: cs:nrpe
103+ charm: ch:nrpe
104 relations:
105 - - kubernetes-master:kube-api-endpoint
106 - kubernetes-worker:kube-api-endpoint
107diff --git a/tests/functional/tests/bundles/jammy.yaml b/tests/functional/tests/bundles/jammy.yaml
108new file mode 100644
109index 0000000..64a2617
110--- /dev/null
111+++ b/tests/functional/tests/bundles/jammy.yaml
112@@ -0,0 +1,65 @@
113+# Note(sudeephb): The charms which are not supported in jammy, or
114+# cause errors on other related charms are deployed in focal
115+applications:
116+ kubernetes-service-checks:
117+ num_units: 1
118+ containerd:
119+ charm: ch:containers-containerd
120+ series: focal
121+ options:
122+ gpu_driver: none
123+ resources: {}
124+ easyrsa:
125+ charm: ch:containers-easyrsa
126+ num_units: 1
127+ series: focal
128+ etcd:
129+ charm: ch:etcd
130+ num_units: 1
131+ flannel:
132+ charm: ch:containers-flannel
133+ series: focal
134+ kubernetes-master:
135+ charm: ch:kubernetes-control-plane
136+ num_units: 1
137+ constraints: cores=4 mem=4G root-disk=16G
138+ series: focal
139+ kubernetes-worker:
140+ charm: ch:kubernetes-worker
141+ expose: true
142+ num_units: 3
143+ constraints: cores=4 mem=4G root-disk=16G
144+ series: focal
145+ options:
146+ kubelet-extra-config: '{protectKernelDefaults: false}'
147+ nrpe:
148+ charm: ch:nrpe
149+relations:
150+ - - kubernetes-master:kube-api-endpoint
151+ - kubernetes-worker:kube-api-endpoint
152+ - - kubernetes-service-checks:nrpe-external-master
153+ - nrpe:nrpe-external-master
154+ - - kubernetes-master:kube-control
155+ - kubernetes-worker:kube-control
156+ - - kubernetes-master:certificates
157+ - easyrsa:client
158+ - - etcd:certificates
159+ - easyrsa:client
160+ - - kubernetes-master:etcd
161+ - etcd:db
162+ - - kubernetes-worker:certificates
163+ - easyrsa:client
164+ - - flannel:etcd
165+ - etcd:db
166+ - - flannel:cni
167+ - kubernetes-master:cni
168+ - - flannel:cni
169+ - kubernetes-worker:cni
170+ - - containerd:containerd
171+ - kubernetes-worker:container-runtime
172+ - - containerd:containerd
173+ - kubernetes-master:container-runtime
174+ - - kubernetes-service-checks:kube-control
175+ - kubernetes-master:kube-control
176+ - - kubernetes-service-checks:kube-api-endpoint
177+ - kubernetes-master:kube-api-endpoint
178diff --git a/tests/functional/tests/bundles/overlays/jammy.yaml.j2 b/tests/functional/tests/bundles/overlays/jammy.yaml.j2
179new file mode 100644
180index 0000000..bc860fa
181--- /dev/null
182+++ b/tests/functional/tests/bundles/overlays/jammy.yaml.j2
183@@ -0,0 +1 @@
184+series: jammy
185diff --git a/tests/functional/tests/tests.yaml b/tests/functional/tests/tests.yaml
186index 1abf43c..f1fea00 100644
187--- a/tests/functional/tests/tests.yaml
188+++ b/tests/functional/tests/tests.yaml
189@@ -8,7 +8,7 @@ target_deploy_status:
190 workload-status-message: "missing kube-api-endpoint relation"
191 kubernetes-master:
192 workload-status: active
193- workload-status-message: "Kubernetes master running."
194+ workload-status-message: "Kubernetes control-plane running."
195 kubernetes-worker:
196 workload-status: active
197 workload-status-message: "Kubernetes worker running."
198@@ -28,7 +28,8 @@ target_deploy_status:
199 workload-status: blocked
200 workload-status-message: Nagios server not configured or related
201 gate_bundles:
202- - bionic
203+ - jammy
204 - focal
205+ - bionic
206 smoke_bundles:
207 - focal

Subscribers

People subscribed via source and target branches

to all changes: