Unity SoundCloud Scope

Merge lp:~submarine/unity-scope-soundcloud/module_moduletype into lp:unity-scope-soundcloud/legacy

  1. module_moduletype
  2. Merge into trunk
Proposed by David Callé
Status: Merged
Approved by: James Henstridge
Approved revision: 32
Merged at revision: 32
Proposed branch: lp:~submarine/unity-scope-soundcloud/module_moduletype
Merge into: lp:unity-scope-soundcloud/legacy
Diff against target: 21 lines (+3/-1)
2 files modified
data/soundcloud.scope.in (+2/-0)
data/unity-scope-soundcloud.service (+1/-1)
To merge this branch: bzr merge lp:~submarine/unity-scope-soundcloud/module_moduletype
Reviewer Review Type Date Requested Status
James Henstridge Approve
PS Jenkins bot (community) continuous-integration Approve
Review via email: mp+173433@code.launchpad.net

Commit message

Add module and moduletype

Description of the change

Add module and moduletype

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

PASSED: Continuous integration, rev:32
http://jenkins.qa.ubuntu.com/job/unity-scope-soundcloud-ci/3/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-scope-soundcloud-saucy-amd64-ci/1
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-scope-soundcloud-saucy-armhf-ci/1
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-scope-soundcloud-saucy-i386-ci/1

Click here to trigger a rebuild:
http://s-jenkins:8080/job/unity-scope-soundcloud-ci/3/rebuild

review: Approve (continuous-integration)
Revision history for this message
James Henstridge (jamesh) wrote :

Looks good.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'data/soundcloud.scope.in'
2--- data/soundcloud.scope.in 2013-04-26 14:38:12 +0000
3+++ data/soundcloud.scope.in 2013-07-08 07:54:47 +0000
4@@ -6,6 +6,8 @@
5 RequiredMetadata=album[s];artist[s];
6 OptionalMetadata=genre[s];label[s];license[s];stream[s];
7 Loader=/usr/share/unity-scopes/soundcloud/unity_soundcloud_daemon.py
8+Module=soundcloud.unity_soundcloud_daemon
9+ModuleType=python3
10 RemoteContent=true
11 Type=music
12 _Name=SoundCloud
13
14=== modified file 'data/unity-scope-soundcloud.service'
15--- data/unity-scope-soundcloud.service 2013-03-14 12:29:11 +0000
16+++ data/unity-scope-soundcloud.service 2013-07-08 07:54:47 +0000
17@@ -1,3 +1,3 @@
18 [D-BUS Service]
19 Name=com.canonical.Unity.Scope.Music.Soundcloud
20-Exec=/usr/bin/python3 /usr/share/unity-scopes/scope-runner-dbus.py /usr/share/unity-scopes/soundcloud/unity_soundcloud_daemon.py
21+Exec=/usr/bin/python3 /usr/share/unity-scopes/scope-runner-dbus.py -s music/soundcloud.scope

Subscribers

People subscribed via source and target branches

to all changes: