Unity Chromium Bookmarks Scope

Merge lp:~submarine/unity-scope-chromiumbookmarks/new-icon into lp:unity-scope-chromiumbookmarks

  1. new-icon
  2. Merge into trunk
Proposed by David Callé
Status: Merged
Approved by: Paweł Stołowski
Approved revision: 32
Merged at revision: 32
Proposed branch: lp:~submarine/unity-scope-chromiumbookmarks/new-icon
Merge into: lp:unity-scope-chromiumbookmarks
Diff against target: 35 lines (+4/-4)
2 files modified
data/chromiumbookmarks.scope.in (+1/-1)
src/unity_chromiumbookmarks_daemon.py (+3/-3)
To merge this branch: bzr merge lp:~submarine/unity-scope-chromiumbookmarks/new-icon
Reviewer Review Type Date Requested Status
Paweł Stołowski (community) Approve
PS Jenkins bot (community) continuous-integration Approve
Review via email: mp+168082@code.launchpad.net

Commit message

Use the bookmark icon and change Show to Open

Description of the change

Use the bookmarks icon
Change Show to Open (to match other scopes)

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

PASSED: Continuous integration, rev:32
http://jenkins.qa.ubuntu.com/job/unity-scope-chromiumbookmarks-ci/7/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-scope-chromiumbookmarks-saucy-amd64-ci/1
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-scope-chromiumbookmarks-saucy-armhf-ci/1
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-scope-chromiumbookmarks-saucy-i386-ci/1

Click here to trigger a rebuild:
http://s-jenkins:8080/job/unity-scope-chromiumbookmarks-ci/7/rebuild

review: Approve (continuous-integration)
Revision history for this message
Paweł Stołowski (stolowski) wrote :

+1

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'data/chromiumbookmarks.scope.in'
2--- data/chromiumbookmarks.scope.in 2013-05-02 16:27:27 +0000
3+++ data/chromiumbookmarks.scope.in 2013-06-07 14:31:40 +0000
4@@ -1,7 +1,7 @@
5 [Scope]
6 DBusName=com.canonical.Unity.Scope.Webhistory.Chromiumbookmarks
7 DBusPath=/com/canonical/unity/scope/webhistory/chromiumbookmarks
8-Icon=
9+Icon=/usr/share/icons/unity-icon-theme/places/svg/group-browserbookmarks.svg
10 QueryBinary=chromium-browser
11 _Keywords=chromiumbookmarks;chromium;web;bookmarks;
12 RequiredMetadata=
13
14=== modified file 'src/unity_chromiumbookmarks_daemon.py'
15--- src/unity_chromiumbookmarks_daemon.py 2013-05-16 14:36:51 +0000
16+++ src/unity_chromiumbookmarks_daemon.py 2013-06-07 14:31:40 +0000
17@@ -37,8 +37,8 @@
18 NO_RESULTS_HINT = _('Sorry, there are no Bookmarks that match your search.')
19 PROVIDER_CREDITS = _('')
20 SVG_DIR = '/usr/share/icons/unity-icon-theme/places/svg/'
21-PROVIDER_ICON = SVG_DIR + 'service-chromiumbookmarks.svg'
22-DEFAULT_RESULT_ICON = 'gtk-about'
23+PROVIDER_ICON = SVG_DIR + 'group-browserbookmarks.svg'
24+DEFAULT_RESULT_ICON = SVG_DIR + 'group-browserbookmarks.svg'
25 DEFAULT_RESULT_MIMETYPE = 'text/html'
26 DEFAULT_RESULT_TYPE = Unity.ResultType.DEFAULT
27 DEFAULT_BOOKMARKS = os.getenv("HOME") + "/.config/chromium/Default/Bookmarks"
28@@ -202,7 +202,7 @@
29 preview.props.image_source_uri = 'file://' + self.result.icon_hint
30 else:
31 preview.props.image = Gio.ThemedIcon.new('gtk-about')
32- show_action = Unity.PreviewAction.new("show", _("Show"), None)
33+ show_action = Unity.PreviewAction.new("show", _("Open"), None)
34 preview.add_action(show_action)
35 return preview
36

Subscribers

People subscribed via source and target branches

to all changes: