Merge lp:~stylistica/mailman/user_preferences into lp:mailman

[Sneha Priscilla]

A small fix to add a missing hide_address reference. Required for Postorius user preferences.

Should I submit this as a patch?

[Barry Warsaw (barry)]

Hi! Thanks for this branch. Now that I have the test suite working again, I can merge this in.

I'm going to accept this branch, but let me just mention a few things that may make future branches easier to review.

* Please use only spaces for indentation, never tabs. Be sure your editor never uses tabs for Mailman code specifically, and (IMHO) Python code in general.

* There were no tests, but an existing test failed. In this case, it would be fine if the existing test were fixed. Please learn how to run the test suite and watch out for test failures. If you feel like you need help with adding tests, please let us know on the mailing list!

I've fixed the tabs and tests... thanks!

review: Approve

[Barry Warsaw (barry)]

Oh, and submitting this as a branch is definitely preferred over a patch. :)

=== modified file 'src/mailman/rest/preferences.py'
--- src/mailman/rest/preferences.py	2013-01-01 14:05:42 +0000
+++ src/mailman/rest/preferences.py	2013-08-08 20:52:32 +0000
@@ -84,6 +84,7 @@
             return http.not_found()
         kws = dict(
             acknowledge_posts=GetterSetter(as_boolean),
+	    hide_address = GetterSetter(as_boolean),
             delivery_mode=GetterSetter(enum_validator(DeliveryMode)),
             delivery_status=GetterSetter(enum_validator(DeliveryStatus)),
             preferred_language=GetterSetter(language_validator),