Merge lp:~stylesen/lava-scheduler/multinode into lp:lava-scheduler/multinode

Proposed by Senthil Kumaran S
Status: Merged
Approved by: Neil Williams
Approved revision: no longer in the source branch.
Merged at revision: 263
Proposed branch: lp:~stylesen/lava-scheduler/multinode
Merge into: lp:lava-scheduler/multinode
Diff against target: 36 lines (+14/-1)
2 files modified
lava_scheduler_app/templates/lava_scheduler_app/job_submit.html (+10/-0)
lava_scheduler_app/views.py (+4/-1)
To merge this branch: bzr merge lp:~stylesen/lava-scheduler/multinode
Reviewer Review Type Date Requested Status
Neil Williams Approve
Review via email: mp+172974@code.launchpad.net

Description of the change

Fix error while submitting multinode job via UI.

To post a comment you must log in.
Revision history for this message
Neil Williams (codehelp) wrote :

Tested on multinode.validation.linaro.org, approved.

review: Approve
263. By Neil Williams

Senthil Kumaran 2013-07-04 Fix error while submitting multinode job via UI.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'lava_scheduler_app/templates/lava_scheduler_app/job_submit.html'
2--- lava_scheduler_app/templates/lava_scheduler_app/job_submit.html 2013-06-28 09:43:44 +0000
3+++ lava_scheduler_app/templates/lava_scheduler_app/job_submit.html 2013-07-04 08:56:28 +0000
4@@ -31,6 +31,16 @@
5 To view the full job list click <a href="{{ list_url }}">here</a>.
6 </div>
7
8+{% elif job_list %}
9+{% url lava.scheduler.job.list as list_url %}
10+<div id="job-success">Multinode Job submission successfull!
11+<br>
12+<br>
13+Jobs with ID {{ job_list }}</a> has been created.
14+<br>
15+To view the full job list click <a href="{{ list_url }}">here</a>.
16+</div>
17+
18 {% else %}
19
20 {% if error %}
21
22=== modified file 'lava_scheduler_app/views.py'
23--- lava_scheduler_app/views.py 2013-07-04 05:22:29 +0000
24+++ lava_scheduler_app/views.py 2013-07-04 08:56:28 +0000
25@@ -599,7 +599,10 @@
26 job = TestJob.from_json_and_user(
27 request.POST.get("json-input"), request.user)
28
29- response_data["job_id"] = job.id
30+ if isinstance(job, type(list())):
31+ response_data["job_list"] = job
32+ else:
33+ response_data["job_id"] = job.id
34 return render_to_response(
35 "lava_scheduler_app/job_submit.html",
36 response_data, RequestContext(request))

Subscribers

People subscribed via source and target branches

to status/vote changes: