Merge lp:~stylesen/lava-scheduler/fix-bug-1224261 into lp:lava-scheduler

Proposed by Senthil Kumaran S
Status: Merged
Approved by: Neil Williams
Approved revision: 263
Merged at revision: 265
Proposed branch: lp:~stylesen/lava-scheduler/fix-bug-1224261
Merge into: lp:lava-scheduler
Diff against target: 43 lines (+5/-3)
2 files modified
lava_scheduler_app/models.py (+1/-1)
lava_scheduler_app/views.py (+4/-2)
To merge this branch: bzr merge lp:~stylesen/lava-scheduler/fix-bug-1224261
Reviewer Review Type Date Requested Status
Neil Williams Approve
Review via email: mp+185207@code.launchpad.net

Description of the change

Fix bug #1224261 - submitting a multinode job for a device_type with no boards fails.

To post a comment you must log in.
Revision history for this message
Neil Williams (codehelp) wrote :

Tested on playground, approved. Thanks.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'lava_scheduler_app/models.py'
2--- lava_scheduler_app/models.py 2013-09-04 14:46:59 +0000
3+++ lava_scheduler_app/models.py 2013-09-12 06:35:06 +0000
4@@ -81,7 +81,7 @@
5 continue
6 else:
7 raise DevicesUnavailableException(
8- "Requested %d %s device(s) - only %d available." % (count, board, all_devices[board]))
9+ "Requested %d %s device(s) - only %d available." % (count, board, all_devices.get(board,0)))
10 return True
11
12
13
14=== modified file 'lava_scheduler_app/views.py'
15--- lava_scheduler_app/views.py 2013-09-02 15:14:15 +0000
16+++ lava_scheduler_app/views.py 2013-09-12 06:35:06 +0000
17@@ -53,6 +53,7 @@
18 TestJob,
19 JSONDataError,
20 validate_job_json,
21+ DevicesUnavailableException,
22 )
23
24
25@@ -606,7 +607,8 @@
26 "lava_scheduler_app/job_submit.html",
27 response_data, RequestContext(request))
28
29- except (JSONDataError, ValueError) as e:
30+ except (JSONDataError, ValueError, DevicesUnavailableException) \
31+ as e:
32 response_data["error"] = str(e)
33 response_data["json_input"] = request.POST.get("json-input")
34 return render_to_response(
35@@ -842,7 +844,7 @@
36 response_data, RequestContext(request))
37 else:
38 return redirect(job)
39- except Exception as e:
40+ except (JSONDataError, ValueError, DevicesUnavailableException) as e:
41 response_data["error"] = str(e)
42 response_data["json_input"] = definition
43 return render_to_response(

Subscribers

People subscribed via source and target branches