Merge lp:~stylesen/lava-dispatcher/fix-empty-parse-pattern into lp:lava-dispatcher

Proposed by Senthil Kumaran S
Status: Merged
Merged at revision: 453
Proposed branch: lp:~stylesen/lava-dispatcher/fix-empty-parse-pattern
Merge into: lp:lava-dispatcher
Diff against target: 0 lines
To merge this branch: bzr merge lp:~stylesen/lava-dispatcher/fix-empty-parse-pattern
Reviewer Review Type Date Requested Status
Andy Doan (community) Approve
Review via email: mp+134646@code.launchpad.net

Description of the change

[Bug #1079642 ] Fix for test definitions which does not have a parse pattern.

To post a comment you must log in.
Revision history for this message
Andy Doan (doanac) wrote :

Two comments:

1) you could also do this with only 2 lines of change with:
 if 'parse' not in testdef:
     return []

2) I don't completely agree with this bug. Its going to be odd to have a test that has no results. And this could confuse someone. So, at a minimum I think we should log a warning like:

 if 'parse' not in testdef:
     logging.warning('The test definition contains no result parsing rule')
     return []

453. By Senthil Kumaran S

[Bug #1079642] Give a default pattern to parse, if one is not specified in
the test definition.

Revision history for this message
Andy Doan (doanac) wrote :

small typo "fal":

 defpat = "(?P<test_case_id>.*-*)\\s+:\\s+(?P<result>(PASS|FAIL|pass|fal))"

You also lefted out "skip|SKIP"

Revision history for this message
Andy Doan (doanac) :
review: Approve
454. By Senthil Kumaran S

Fix a small typo in the parse pattern and add more default result values.

Preview Diff

Empty

Subscribers

People subscribed via source and target branches