Merge lp:~stylesen/lava-dispatcher/fix-bug-1212589 into lp:lava-dispatcher

[Senthil Kumaran S]

Fix bug #1212589 - dependencies are not installed before executing the tests.

[Fathi Boudra (fboudra)]

please fix the message:
 echo "${PREFIX} DEBUG: Dependencies will not be installed since the test image failed to bring up the network interface ..."

It should be a WARNING at least, not DEBUG. Also the message could be improved.
You assume the test image failed to bring up the network interface but you don't know. It could be hardware issue or on purpose.

Stick to the fact: Network interface is down. Dependencies will not be installed.

review: Needs Fixing

[Senthil Kumaran S (stylesen)]

Hi Fathi,

On Tuesday 20 August 2013 11:25 AM, Fathi Boudra wrote:
> Stick to the fact: Network interface is down. Dependencies will not be installed.

I shall use the above statement as a warning.

Thank You.
--
Senthil Kumaran
http://www.stylesen.org/
http://www.sasenthilkumaran.com/

[lp:~stylesen/lava-dispatcher/fix-bug-1212589]

654. By Senthil Kumaran S on 2013-08-20

Improve the warning message if the dependencies fail to install.

Suggested by: fabo

[Fathi Boudra (fboudra)]

Thanks. Ship it!

review: Approve

=== modified file 'lava_test_shell/lava-test-runner'
--- lava_test_shell/lava-test-runner	2013-04-11 19:50:48 +0000
+++ lava_test_shell/lava-test-runner	2013-08-20 06:12:38 +0000
@@ -51,15 +51,23 @@
 echo "${PREFIX} looking for installation work in ${WORKFILE}"
 for line in $(cat ${WORKFILE}); do
 	test=`basename $line`
+        echo "${PREFIX} Check if network interface is up ..."
 	if [ -f ${line}/install.sh ] ; then
-		echo "${PREFIX} running ${test} installer ..."
-		/bin/sh ${line}/install.sh
-		if [ $? -ne 0 ] ; then
-			echo "${PREFIX} ${test} installer failed, exiting"
-			hwcontext
-			swcontext
-			exit 1
-		fi
+            /bin/ping -W1 -c1 8.8.8.8
+            if [ $? -ne 0 ] ; then
+                echo "${PREFIX} WARNING: Network interface is down. Dependencies will not be installed."
+		hwcontext
+		swcontext
+                exit 1
+            fi
+	    echo "${PREFIX} running ${test} installer ..."
+	    /bin/sh ${line}/install.sh
+	    if [ $? -ne 0 ] ; then
+		echo "${PREFIX} ${test} installer failed, exiting"
+		hwcontext
+		swcontext
+		exit 1
+	    fi
 	fi
 done