Merge lp:~stub/launchpad/garbo into lp:launchpad
|Approved by:||Curtis Hovey on 2012-04-25|
|Merged at revision:||15151|
|Diff against target:||
29 lines (+7/-4)
1 file modified
|To merge this branch:||bzr merge lp:~stub/launchpad/garbo|
Description of the Change
= Summary =
garbo.py isn't thread safe, and occasionally OOPSes when a list is accessed in a non-thread safe fashion.
== Proposed fix ==
Access the list in a thread safe fashion. We could replace the list with a Queue, but that seems to increase complexity for little gain.
== Pre-implementation notes ==
== LOC Rationale ==
== Implementation details ==
== Tests ==
Existing tests pass. I'm unable to write a test to force the race condition.
== Demo and Q/A ==
= Launchpad lint =
Checking for conflicts and issues in changed files.
Linting changed files: