Merge lp:~stub/launchpad/db-cleanups into lp:launchpad/db-devel
Status: | Merged |
---|---|
Approved by: | Stuart Bishop |
Approved revision: | no longer in the source branch. |
Merged at revision: | 10815 |
Proposed branch: | lp:~stub/launchpad/db-cleanups |
Merge into: | lp:launchpad/db-devel |
Prerequisite: | lp:~stub/launchpad/pending-db-changes |
Diff against target: |
51 lines (+10/-4) 3 files modified
cronscripts/generate-contents-files.py (+1/-2) cronscripts/publish-ftpmaster.py (+1/-2) database/schema/security.cfg (+8/-0) |
To merge this branch: | bzr merge lp:~stub/launchpad/db-cleanups |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Robert Collins (community) | Approve | ||
Review via email: mp+69038@code.launchpad.net |
Commit message
[r=lifeless][bug=815753] Fix publish-ftpmaster and generate-
Description of the change
= Summary =
Scripts should all connect as unique database users.
== Proposed fix ==
Fix this.
== Pre-implementation notes ==
== Implementation details ==
This branch fixes three cronscripts connecting as the archivepublisher dbuser.
== Tests ==
== Demo and Q/A ==
= Launchpad lint =
Checking for conflicts and issues in changed files.
Linting changed files:
database/
cronscripts/
cronscripts/
cronscripts/
./cronscripts/
8: '_pythonpath' imported but unused
./cronscripts/
10: '_pythonpath' imported but unused
./cronscripts/
8: '_pythonpath' imported but unused
Looks fine to me, though perhaps we want some guidelines somewhere about when to hard code and when to use the config (for dbuser).