Merge lp:~stub/launchpad/bug-675562-readonly-violation into lp:launchpad
Proposed by
Stuart Bishop
Status: | Merged |
---|---|
Approved by: | Stuart Bishop |
Approved revision: | no longer in the source branch. |
Merged at revision: | 11932 |
Proposed branch: | lp:~stub/launchpad/bug-675562-readonly-violation |
Merge into: | lp:launchpad |
Diff against target: |
229 lines (+82/-14) 4 files modified
lib/canonical/launchpad/doc/db-policy.txt (+26/-0) lib/canonical/launchpad/tests/readonly.py (+18/-1) lib/canonical/launchpad/webapp/adapter.py (+33/-13) lib/canonical/launchpad/webapp/dbpolicy.py (+5/-0) |
To merge this branch: | bzr merge lp:~stub/launchpad/bug-675562-readonly-violation |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Jeroen T. Vermeulen (community) | Approve | ||
Review via email: mp+41034@code.launchpad.net |
Commit message
[r=jtv][ui=none][bug=675562] Fail requests for master stores if we are in read-only mode, no matter what database policy is currently installed.
Description of the change
Fail requests for master stores if we are in read-only mode, no matter what database policy is currently installed.
To post a comment you must log in.
Nice branch. Thanks for the drive-by cleanups, too.
Only found some very small things to nag about: launchpad/ webapp/ adapter. py, our coding standard says the "if/elif" should have an "else" as well.
* May be better to test against the absence of IMasterStore (as well as, or in place of) the presence of ISlaveStore. In case the design changes.
* In lib/canonical/
Jeroen