Merge lp:~stub/launchpad/bug-3050 into lp:launchpad

[Stuart Bishop]

[Stuart Bishop (stub)]

All scripts now connect as an explicit database user, so we can finally close long standing Bug #3050.

[Jonathan Lange (jml)]

Hi stub,

Thanks for getting to this! Please run the tests before landing (may I recommend ec2 land?).

jml

review: Approve

=== modified file 'lib/canonical/database/sqlbase.py'
--- lib/canonical/database/sqlbase.py	2009-07-19 04:41:14 +0000
+++ lib/canonical/database/sqlbase.py	2009-10-07 09:05:26 +0000
@@ -291,8 +291,10 @@
             if match is not None:
                 dbhost = match.group(1)
 
-        if dbuser is None:
-            dbuser = config.launchpad.dbuser
+        assert dbuser is not None, '''
+            dbuser is now required. All scripts must connect as unique
+            database users.
+            '''
 
         isolation_level = {
             ISOLATION_LEVEL_AUTOCOMMIT: 'autocommit',