Merge lp:~stub/codetree/nopy2 into lp:codetree

Proposed by Stuart Bishop
Status: Merged
Approved by: Stuart Bishop
Approved revision: 119
Merged at revision: 119
Proposed branch: lp:~stub/codetree/nopy2
Merge into: lp:codetree
Diff against target: 120 lines (+19/-24)
5 files modified
Makefile (+4/-4)
debian/changelog (+6/-0)
debian/control (+4/-8)
debian/rules (+5/-7)
setup.py (+0/-5)
To merge this branch: bzr merge lp:~stub/codetree/nopy2
Reviewer Review Type Date Requested Status
Tom Haddon Approve
Canonical IS Reviewers Pending
Review via email: mp+385491@code.launchpad.net

Commit message

Drop Python2 support

To post a comment you must log in.
Revision history for this message
🤖 Canonical IS Merge Bot (canonical-is-mergebot) wrote :

This merge proposal is being monitored by mergebot. Change the status to Approved to merge.

lp:~stub/codetree/nopy2 updated
119. By Stuart Bishop

Fix clean build rule under trusty

Revision history for this message
Tom Haddon (mthaddon) wrote :

LGTM, thx

review: Approve
Revision history for this message
🤖 Canonical IS Merge Bot (canonical-is-mergebot) wrote :

Change successfully merged at revision 119

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'Makefile'
2--- Makefile 2020-04-20 06:38:12 +0000
3+++ Makefile 2020-06-10 10:48:33 +0000
4@@ -1,8 +1,8 @@
5 userinstall:
6- python setup.py install --user
7+ python3 setup.py install --user
8
9 install:
10- python setup.py install
11+ python3 setup.py install
12
13 clean:
14 rm -rf build codetree.egg-info dist
15@@ -18,10 +18,10 @@
16 nosetests3 tests/
17
18 dist:
19- bzr export --root=. ../codetree_$$(python setup.py --version).orig.tar.bz2 .
20+ bzr export --root=. ../codetree_$$(python3 setup.py --version).orig.tar.bz2 .
21
22 dch:
23- dch -D trusty --newversion $$(python setup.py -V)-1
24+ dch -D trusty --newversion $$(python3 setup.py -V)-1
25
26 deb: dist dch
27 cd debian && debuild -sa -I.bzr
28
29=== modified file 'debian/changelog'
30--- debian/changelog 2020-05-05 06:22:21 +0000
31+++ debian/changelog 2020-06-10 10:48:33 +0000
32@@ -1,3 +1,9 @@
33+codetree (1.2.0-0) trusty; urgency=medium
34+
35+ * Drop python2 support
36+
37+ -- Stuart Bishop (Work) <stuart.bishop@canonical.com> Wed, 10 Jun 2020 20:20:19 +1000
38+
39 codetree (1.1.1-0) trusty; urgency=medium
40
41 * Ensure git branches stick over multiple runs
42
43=== modified file 'debian/control'
44--- debian/control 2020-04-21 08:09:52 +0000
45+++ debian/control 2020-06-10 10:48:33 +0000
46@@ -3,21 +3,17 @@
47 Section: python
48 Priority: optional
49 Build-Depends: debhelper (>= 7.4.3), dh-python,
50- python-setuptools (>= 0.6b3), python-all (>= 2.6.6-3), python-nose, python-mock,
51 python3-setuptools, python3-all, python3-nose, python3-flake8, python3-mock,
52- python-requests, python-yaml, python-concurrent.futures, git, rsync, unzip, bzr, python3-requests, python3-yaml,
53+ git, rsync, unzip, bzr, python3-requests, python3-yaml,
54 Standards-Version: 3.9.1
55
56-Package: python-codetree
57-Architecture: all
58-Depends: ${misc:Depends}, ${python:Depends},
59- python-requests, python-yaml, python-concurrent.futures, git, rsync, unzip, bzr, python3-codetree
60-Description: A code tree builder
61-
62 # NB. This package contains the codetree executable, but is not called
63 # 'codetree' because there is already an Ubuntu package with that name
64 # for a different tool.
65 Package: python3-codetree
66+Provides: python-codetree (= 1.2.0-0)
67+Replaces: python-codetree (<< 1.2.0-0)
68+Breaks: python-codetree (<< 1.0)
69 Architecture: all
70 Depends: ${misc:Depends}, ${python3:Depends}, python3-requests, python3-yaml, git, rsync, unzip, bzr
71 Description: A code tree builder
72
73=== modified file 'debian/rules'
74--- debian/rules 2020-04-22 02:23:53 +0000
75+++ debian/rules 2020-06-10 10:48:33 +0000
76@@ -4,19 +4,17 @@
77 export LC_ALL=C
78
79 %:
80- dh $@ --buildsystem=python_distutils --with=`dh --list | grep -e "python[2-3]\?$$" | paste -d, -s -`
81+ dh $@ --buildsystem=python_distutils --with=python3
82
83-override_dh_auto_test:
84- echo Tests disabled in package builds due to cross version problems
85+# override_dh_auto_test:
86+# echo Tests disabled in package builds due to cross version problems
87
88 override_dh_auto_clean:
89- dh_auto_clean
90+ python3 setup.py clean -a
91 rm -rf build
92
93 override_dh_auto_build:
94- python2 setup.py build
95 python3 setup.py build
96
97 override_dh_auto_install:
98- python2 setup.py install --root=$(CURDIR)/debian/$(DEB_SOURCE) --install-layout=deb # writes usr/bin/codetree
99- python3 setup.py install --root=$(CURDIR)/debian/$(DEB_SOURCE) --install-layout=deb # rewrites usr/bin/codetree
100+ python3 setup.py install --root=$(CURDIR)/debian/$(DEB_SOURCE) --install-layout=deb
101
102=== modified file 'setup.py'
103--- setup.py 2020-05-05 06:22:21 +0000
104+++ setup.py 2020-06-10 10:48:33 +0000
105@@ -1,4 +1,3 @@
106-from __future__ import division, print_function
107 from setuptools import setup, find_packages
108 import sys
109
110@@ -18,10 +17,6 @@
111 # 'six', six now embedded as codetree.six
112 ]
113
114-if sys.version_info.major == 2:
115- tests_requires.extend(['futures>=3.1.1', 'mock>=2.0'])
116- install_requires.extend(['futures'])
117-
118 setup(
119 name="python-codetree",
120 version="1.1.1",

Subscribers

People subscribed via source and target branches