Merge lp:~stub/charms/precise/postgresql/repoless into lp:charms/postgresql
Status: | Superseded |
---|---|
Proposed branch: | lp:~stub/charms/precise/postgresql/repoless |
Merge into: | lp:charms/postgresql |
Prerequisite: | lp:~stub/charms/precise/postgresql/data-checksums |
Diff against target: |
330 lines (+234/-2) (has conflicts) 7 files modified
lib/test-client-charm/config.yaml (+13/-0) lib/test-client-charm/hooks/hooks.py (+165/-0) lib/test-client-charm/hooks/start (+3/-0) lib/test-client-charm/hooks/stop (+3/-0) lib/test-client-charm/metadata.yaml (+13/-0) test.py (+13/-2) testing/jujufixture.py (+24/-0) Text conflict in hooks/hooks.py |
To merge this branch: | bzr merge lp:~stub/charms/precise/postgresql/repoless |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
charmers | Pending | ||
Review via email: mp+238256@code.launchpad.net |
Commit message
Embed test charms and remove JUJU_REPOSITORY requirement
Description of the change
A common issue with running the PostgreSQL charm is getting JUJU_REPOSITORY setup.
Because the PostgreSQL charm and thus its tests is supported on both trusty and precise, the test suite detects the juju environment's default-series and uses that as the series to use, unless overridden. This in itself isn't a problem, except that the automatic test runner is attempting to run tests with precise, but has a juju environment setup with default-series of trusty, and everything explodes.
Also, the postgresql-psql charm is not in the charm store under trusty, so needed to be in JUJU_REPOSITORY. I elected to not get it pushed to trusty, as its current dual purpose of being a general purpose command line client and for driving tests means it works poorly on both.
While the automatic test runner is getting sorted out, lets do some improvements I'd been planning on anyway. Embed the the client charm our tests need, and build a JUJU_REPOSITORY dynamically.
This still leaves the charm detecting the series to use, so the automatic test runner will continue to actually be running trusty tests when it was hoping for precise, but at least they should pass now. This cannot be fixed until the test environment is setup with a correct default-series, or some other mechanism is available for detecting the series to test against (such as an environment variable).
Unmerged revisions
- 166. By Stuart Bishop
-
Merged data-checksums into repoless.
- 165. By Stuart Bishop
-
Ignore regenerated charmhelpers