Merge lp:~stub/charms/precise/postgresql/cleanups into lp:charms/postgresql
Proposed by
Stuart Bishop
Status: | Merged | ||||
---|---|---|---|---|---|
Merged at revision: | 85 | ||||
Proposed branch: | lp:~stub/charms/precise/postgresql/cleanups | ||||
Merge into: | lp:charms/postgresql | ||||
Prerequisite: | lp:~stub/charms/precise/postgresql/charm-helpers | ||||
Diff against target: |
154 lines (+85/-27) 2 files modified
README.md (+68/-1) hooks/hooks.py (+17/-26) |
||||
To merge this branch: | bzr merge lp:~stub/charms/precise/postgresql/cleanups | ||||
Related bugs: |
|
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Marco Ceppi (community) | Approve | ||
Charles Butler (community) | Approve | ||
Review via email: mp+203701@code.launchpad.net |
Description of the change
Remove an unused helper and fix some edge cases in the relation-broken hooks.
To post a comment you must log in.
Greetings Stuart,
I'm reviewing the merge details and from what I understand is going on here, you're handling some cases where access to the data would happen due to another hook stripping access from the proposed user correct?
I've deployed this branch and poked about in postgres. The block was reached and defaulted away from removing access from the user, which was nice to see that its idempotent in caring about data access and integrity after the relationship departs.
You get my +1, and if I was off base in the review please correct me.
Thanks for your continued effort on maintaining a high quality charm. Another member of the charmers team will be along shortly to continue the review and potentially promulgate your changes.