Merge lp:~stub/charm-helpers/bug-1185743-add-pwgen into lp:charm-helpers

[Stuart Bishop]

Add a pwgen helper per Bug #1185743

[lp:~stub/charm-helpers/bug-1185743-add-pwgen]

37. By Stuart Bishop on 2013-07-09

Merged bug-1195649-fix-write-file into bug-1185743-add-pwgen.

38. By Stuart Bishop on 2013-07-09

Merged bug-1195649-fix-write-file into bug-1185743-add-pwgen.

[Liam Young (gnuoy)]

LGTM once the prereq branch is merged. ( vowels are excluded to avoid accidental obscenities and l0QD1v are excluded because they look the same using some fonts )

review: Approve

=== modified file 'charmhelpers/core/host.py'
--- charmhelpers/core/host.py	2013-07-09 10:50:35 +0000
+++ charmhelpers/core/host.py	2013-07-09 10:50:35 +0000
@@ -9,6 +9,8 @@
 import os
 import pwd
 import grp
+import random
+import string
 import subprocess
 import hashlib
 
@@ -258,3 +260,15 @@
             k, v = l.split('=')
             d[k.strip()] = v.strip()
     return d
+
+
+def pwgen(length=None):
+    '''Generate a random pasword.'''
+    if length is None:
+        length = random.choice(range(35, 45))
+    alphanumeric_chars = [
+        l for l in (string.letters + string.digits)
+        if l not in 'l0QD1vAEIOUaeiou']
+    random_chars = [
+        random.choice(alphanumeric_chars) for _ in range(length)]
+    return(''.join(random_chars))

=== modified file 'tests/core/test_host.py'
--- tests/core/test_host.py	2013-07-09 10:50:35 +0000
+++ tests/core/test_host.py	2013-07-09 10:50:35 +0000
@@ -729,3 +729,13 @@
             for key in result:
                 print lsb_release
                 self.assertEqual(result[key], lsb_release[key])
+
+    def test_pwgen(self):
+        pw = host.pwgen()
+        self.assert_(len(pw) >= 35, 'Password is too short')
+
+        pw = host.pwgen(10)
+        self.assertEqual(len(pw), 10, 'Password incorrect length')
+
+        pw2 = host.pwgen(10)
+        self.assertNotEqual(pw, pw2, 'Duplicated password')