Merge lp:~stuartmetcalfe/django-openid-auth/staff-assignment into lp:~django-openid-auth/django-openid-auth/trunk
Proposed by
Stuart Metcalfe
Status: | Merged | ||||
---|---|---|---|---|---|
Approved by: | James Henstridge | ||||
Approved revision: | 77 | ||||
Merged at revision: | 75 | ||||
Proposed branch: | lp:~stuartmetcalfe/django-openid-auth/staff-assignment | ||||
Merge into: | lp:~django-openid-auth/django-openid-auth/trunk | ||||
Diff against target: |
107 lines (+70/-2) 2 files modified
django_openid_auth/auth.py (+16/-0) django_openid_auth/tests/test_views.py (+54/-2) |
||||
To merge this branch: | bzr merge lp:~stuartmetcalfe/django-openid-auth/staff-assignment | ||||
Related bugs: |
|
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
James Henstridge | Approve | ||
Anthony Lenton | Approve | ||
Review via email: mp+38469@code.launchpad.net |
Description of the change
This branch adds functionality to set staff status for specified teams, as requested in bug #388414. If the user is in any of the teams named in settings.
To post a comment you must log in.
Folowing some additional thought, I've prevented altering staff status if OPENID_ LAUNCHPAD_ STAFF_TEAMS isn't defined and refactored my tests slightly to reduce repetition (in rev.76). This is now definitely ready for review.