Merge lp:~stolowski/unity-scopes-api/mock-docs into lp:unity-scopes-api/devel

Proposed by Paweł Stołowski
Status: Merged
Approved by: Pete Woods
Approved revision: 572
Merged at revision: 573
Proposed branch: lp:~stolowski/unity-scopes-api/mock-docs
Merge into: lp:unity-scopes-api/devel
Diff against target: 96 lines (+21/-7)
3 files modified
include/unity/scopes/testing/MockPreviewReply.h (+5/-3)
include/unity/scopes/testing/MockSearchReply.h (+6/-3)
include/unity/scopes/testing/TypedScopeFixture.h (+10/-1)
To merge this branch: bzr merge lp:~stolowski/unity-scopes-api/mock-docs
Reviewer Review Type Date Requested Status
PS Jenkins bot (community) continuous-integration Approve
Pete Woods (community) Approve
Review via email: mp+255800@code.launchpad.net

Commit message

Provide brief docstrings for mock classes so that they show up in doxygen documentation.

Description of the change

Provide brief docstrings for mock classes so that they show up in doxygen documentation.
Note, this just makes these 3 classes show up, but no methods are listed since they are in cond/endcond blocks.

To post a comment you must log in.
Revision history for this message
Pete Woods (pete-woods) :
review: Approve
Revision history for this message
PS Jenkins bot (ps-jenkins) :
review: Approve (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'include/unity/scopes/testing/MockPreviewReply.h'
2--- include/unity/scopes/testing/MockPreviewReply.h 2015-02-06 00:25:05 +0000
3+++ include/unity/scopes/testing/MockPreviewReply.h 2015-04-10 10:11:53 +0000
4@@ -33,11 +33,13 @@
5 namespace testing
6 {
7
8-/// @cond
9-
10+/**
11+ \brief Mock for unity::scopes::PreviewReply class.
12+ */
13 class MockPreviewReply : public unity::scopes::PreviewReply, public unity::scopes::testing::MockObject
14 {
15 public:
16+ /// @cond
17 MockPreviewReply() = default;
18
19 // From Reply
20@@ -49,9 +51,9 @@
21 MOCK_METHOD1(register_layout, bool(ColumnLayoutList const&));
22 MOCK_METHOD1(push, bool(PreviewWidgetList const&));
23 MOCK_METHOD2(push, bool(std::string const&, Variant const&));
24+/// @endcond
25 };
26
27-/// @endcond
28
29 } // namespace testing
30
31
32=== modified file 'include/unity/scopes/testing/MockSearchReply.h'
33--- include/unity/scopes/testing/MockSearchReply.h 2015-02-12 23:21:47 +0000
34+++ include/unity/scopes/testing/MockSearchReply.h 2015-04-10 10:11:53 +0000
35@@ -35,11 +35,13 @@
36 namespace testing
37 {
38
39-/// @cond
40-
41+/**
42+ \brief Mock for unity::scopes::SearchReply class.
43+ */
44 class MockSearchReply : public unity::scopes::SearchReply, public virtual MockObject
45 {
46 public:
47+/// @cond
48 MockSearchReply() = default;
49
50 // From Reply
51@@ -66,9 +68,10 @@
52 MOCK_METHOD2(push, bool(Filters const&, FilterState const&));
53 MOCK_METHOD1(push, bool(experimental::Annotation const& annotation));
54 MOCK_METHOD0(push_surfacing_results_from_cache, void());
55+
56+/// @endcond
57 };
58
59-/// @endcond
60
61 } // namespace testing
62
63
64=== modified file 'include/unity/scopes/testing/TypedScopeFixture.h'
65--- include/unity/scopes/testing/TypedScopeFixture.h 2015-02-22 22:27:09 +0000
66+++ include/unity/scopes/testing/TypedScopeFixture.h 2015-04-10 10:11:53 +0000
67@@ -65,10 +65,19 @@
68 friend class TypedScopeFixture;
69 };
70
71+/// @endcond
72+
73+/**
74+ \brief Fixture for testing scope testing.
75+
76+ This fixture template provides convienience SetUp() and TearDown() functions, as well as
77+ a number of setters that ease the creation of scope tests.
78+ */
79 template<typename Scope>
80 class TypedScopeFixture : public ::testing::Test
81 {
82 public:
83+/// @cond
84 TypedScopeFixture()
85 : registry_proxy(&registry, [](unity::scopes::Registry*) {})
86 , scope(ScopeTraits<Scope>::construct())
87@@ -116,9 +125,9 @@
88 unity::scopes::testing::MockRegistry registry;
89 unity::scopes::RegistryProxy registry_proxy;
90 std::shared_ptr<Scope> scope;
91+/// @endcond
92 };
93
94-/// @endcond
95
96 } // namespace testing
97

Subscribers

People subscribed via source and target branches

to all changes: