lp:~stolowski/unity-scope-onlinemusic/honor-disabled-scopes

Branch merges

Propose for merging

No branches dependent on this one.

Merged into lp:unity-scope-onlinemusic at revision 42

PS Jenkins bot (community): Approve (continuous-integration) on 2013-10-14

Michal Hruby (community): Approve on 2013-10-14

Diff: 408 lines (+185/-11)

9 files modified

src/CMakeLists.txt (+3/-2)
src/OnlineMusicScope.cpp (+47/-5)
src/OnlineMusicScope.h (+9/-0)
src/SmartScopesClient.cpp (+7/-2)
src/SmartScopesClient.h (+5/-2)
tests/CMakeLists.txt (+25/-0)
tests/SmartScopesClientTest.cpp (+56/-0)
tests/SmartScopesClientTest.h (+32/-0)
tests/SmartScopesParserTest.cpp (+1/-0)

api

Related source package recipes

No recipes using this branch. (?)

Create packaging recipe

Related snap packages

Related bugs

Bug #1239706: disabled-scopes dconf key is not honored

High

Fix Committed

Link a bug report

Related blueprints

48. By Paweł Stołowski on 2013-10-14

reinterpret_cast -> static_cast.

47. By Paweł Stołowski on 2013-10-14

Renamed queryUnlessDisabled to appendIfEnabled.

46. By Paweł Stołowski on 2013-10-14

Act on review comments.

45. By Paweł Stołowski on 2013-10-14

Don't pass removed_scopes since it's only useful if no scopes param is specified.
Return early if scopes list is empty (all disabled).

44. By Paweł Stołowski on 2013-10-14

Removed invalid unref.

43. By Paweł Stołowski on 2013-10-14

Added tests.

42. By Paweł Stołowski on 2013-10-14

Honor disabled-scopes dconf key.

41. By PS Jenkins bot on 2013-10-07

Releasing 0.1+13.10.20131005.2-0ubuntu1 (revision 40 from lp:unity-scope-onlinemusic).

Approved by PS Jenkins bot.

40. By Paweł Stołowski on 2013-10-04

Set program name to improve error messages from glib.

Approved by PS Jenkins bot, Michal Hruby.

39. By Paweł Stołowski on 2013-10-03

Add &origin=music-onlinemusic.scope to the search query.

Approved by PS Jenkins bot, Michal Hruby.